Bug 713690 - Review Request: rubygem-http_connection - RightScale's robust HTTP/S connection module
Summary: Review Request: rubygem-http_connection - RightScale's robust HTTP/S connecti...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-16 09:13 UTC by Michal Fojtik
Modified: 2011-06-21 17:38 UTC (History)
3 users (show)

Fixed In Version: rubygem-http_connection-1.4.1-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-21 17:12:52 UTC
Type: ---
vondruch: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Michal Fojtik 2011-06-16 09:13:57 UTC
Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec
SRPM URL: rubygem-rbvmomi-1.2.3-1.fc14.src.rpm 
Description:

Rightscale::HttpConnection is a robust HTTP(S) library. It implements a retry
algorithm for low-level network errors.

Comment 1 Michal Fojtik 2011-06-16 09:14:32 UTC
(In reply to comment #0)
> Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec
> SRPM URL: rubygem-rbvmomi-1.2.3-1.fc14.src.rpm 
> Description:
> 
> Rightscale::HttpConnection is a robust HTTP(S) library. It implements a retry
> algorithm for low-level network errors.

Sorry, URL for SRPM is:

http://mifo.sk/tmp/packages/rubygem-rbvmomi-1.2.3-1.fc14.src.rpm

Comment 2 Michal Fojtik 2011-06-16 09:22:13 UTC
Revision 2:

 - Added Provides and Obsoletes
 - Fixed changelog

Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec
SRPM URL: http://mifo.sk/tmp/packages/rubygem-rbvmomi-1.2.3-2.fc14.src.rpm

Comment 3 Michal Fojtik 2011-06-16 09:23:43 UTC
Sorry for the link chaos, is still morning for me ;-)

http://mifo.sk/tmp/packages/rubygem-http_connection-1.4.1-2.fc14.src.rpm

Comment 4 Vít Ondruch 2011-06-16 10:29:31 UTC
I am taking this for review.

According the guidelines for package renaming [1], your provides and obsoletes have to contain correct versions:

Provides: rubygem(%{gemname}) = %{version}
Provides: rubygem-right_http_connection = %{version}
Obsoletes: rubygem-right_http_connection < 1.4.1-1

Also comment that this provides should be removed according to the guidelines would have sense. And don't forget to retire the old package.


Otherwise, the package looks good => APPROVED




[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

Comment 5 Michal Fojtik 2011-06-16 14:07:46 UTC
Thanks for an review Vit! I'll fix that before importing this package.

New Package CVS Request
=======================
Package Name: rubygem-http_connection
Short Description: RightScale's robust HTTP/S connection module
Owners: mfojtik
Branches: F-14 F-15 EL-5 EL-6

Comment 6 Gwyn Ciesla 2011-06-16 14:11:33 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2011-06-16 18:35:19 UTC
rubygem-http_connection-1.4.1-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.fc15

Comment 8 Fedora Update System 2011-06-16 18:42:29 UTC
rubygem-http_connection-1.4.1-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.fc14

Comment 9 Fedora Update System 2011-06-16 18:59:37 UTC
rubygem-http_connection-1.4.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.el6

Comment 10 Fedora Update System 2011-06-21 17:12:46 UTC
rubygem-http_connection-1.4.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 11 Fedora Update System 2011-06-21 17:20:38 UTC
rubygem-http_connection-1.4.1-2.fc14 has been pushed to the Fedora 14 stable repository.

Comment 12 Fedora Update System 2011-06-21 17:38:42 UTC
rubygem-http_connection-1.4.1-2.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.