Created attachment 505033 [details]
Patch to fix

Description of problem:

"pulp-admin repo metadata" produces the following error:

% pulp-admin repo metadata --id generic-5-x86_64-epel
error: operation failed: isinstance() arg 2 must be a class, type, or tuple of classes and types

And the following stack trace in the logs:

2011-06-16 08:48:53,048 [ERROR][Dummy-23] @ base.py:57 - Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/pulp/server/webservices/controllers/base.py", line 53, in report_error
    return method(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/pulp/server/webservices/controllers/base.py", line 132, in _auth_decorator
    value = method(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/pulp/server/webservices/controllers/repositories.py", line 1264, in POST
    return action(id)
  File "/usr/lib/python2.4/site-packages/pulp/server/webservices/controllers/repositories.py", line 647, in metadata
    task = api.metadata(id)
  File "/usr/lib/python2.4/site-packages/pulp/server/api/repo.py", line 1929, in metadata
    task = run_async(self._metadata, [id], {})
  File "/usr/lib/python2.4/site-packages/pulp/server/async.py", line 77, in run_async
    return enqueue(task, unique)
  File "/usr/lib/python2.4/site-packages/pulp/server/async.py", line 48, in enqueue
    _queue.enqueue(task, unique)
  File "/usr/lib/python2.4/site-packages/pulp/server/tasking/taskqueue/queue.py", line 245, in enqueue
    self.__storage.enqueue_waiting(task)
  File "/usr/lib/python2.4/site-packages/pulp/server/tasking/taskqueue/storage.py", line 229, in enqueue_waiting
    self._snapshot_task(task)
  File "/usr/lib/python2.4/site-packages/pulp/server/tasking/taskqueue/storage.py", line 219, in _snapshot_task
    snapshot = task.snapshot()
  File "/usr/lib/python2.4/site-packages/pulp/server/tasking/task.py", line 228, in snapshot
    data[field] = pickle.dumps(getattr(self, field))
  File "/usr/lib64/python2.4/pickle.py", line 1386, in dumps
    Pickler(file, protocol, bin).dump(obj)
  File "/usr/lib64/python2.4/pickle.py", line 231, in dump
    self.save(obj)
  File "/usr/lib64/python2.4/pickle.py", line 338, in save
    self.save_reduce(obj=obj, *rv)
  File "/usr/lib64/python2.4/pickle.py", line 415, in save_reduce
    save(args)
  File "/usr/lib64/python2.4/pickle.py", line 293, in save
    f(self, obj) # Call unbound method with explicit self
  File "/usr/lib64/python2.4/pickle.py", line 576, in save_tuple
    save(element)
  File "/usr/lib64/python2.4/pickle.py", line 313, in save
    rv = reduce(self.proto)
  File "/usr/lib64/python2.4/copy_reg.py", line 83, in _reduce_ex
    dict = getstate()
  File "/usr/lib/python2.4/site-packages/pulp/server/api/repo.py", line 101, in __getstate__
    if not isinstance(v, threading.RLock):
SnapshotFailure: Snapshot of Task fd72bfcf-9816-11e0-bb05-000c291a4507: RepoApi._metadata(generic-5-x86_64-epel, ) failed error pickling field: callable
isinstance() arg 2 must be a class, type, or tuple of classes and types

Version-Release number of selected component (if applicable):

0.0.190, HEAD

How reproducible:

Always

Steps to Reproduce:

1. Run "pulp-admin repo metadata" against any repo.
  
Actual results:

Borks!

Expected results:

Rebuilds metadata.

Additional info:

Patch is attached.