This is a review request for a compat version of mediawiki-semantic (originally reviewed in bug#490001) that can work with mediawiki116. Spec URL: http://jlaska.fedorapeople.org/rpms/mediawiki116-semantic.spec SRPM URL: http://jlaska.fedorapeople.org/rpms/mediawiki116-semantic-1.5.6-1.fc16.src.rpm Description: Semantic MediaWiki (SMW) is a free, open-source extension to MediaWiki – the wiki software that powers Wikipedia – that lets you store and query data within the wiki's pages. Semantic MediaWiki is also a full-fledged framework, in conjunction with many spinoff extensions, that can turn a wiki into a powerful and flexible “collaborative database”. All data created within SMW can easily be published via the Semantic Web, allowing other systems to use this data seamlessly. * koji scratch build (dist-f16) - http://koji.fedoraproject.org/koji/taskinfo?taskID=3138514 * rpmlint output [1] mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza [2] mediawiki116-semantic.noarch: E: incorrect-fsf-address /usr/share/doc/mediawiki116-semantic-1.5.6/COPYING [3] mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza [4] 2 packages and 1 specfiles checked; 1 errors, 2 warnings. [1,3] These are just warnings and I don't believe they are critical [2] I have notified upstream - https://bugzilla.wikimedia.org/show_bug.cgi?id=29458
I'd be happy to review this. Look for a full review in a bit here.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: a436f07cd3be24ae99ff33b748c6c664 SemanticMediaWiki1.5.6.tgz a436f07cd3be24ae99ff33b748c6c664 ../SOURCES/SemanticMediaWiki1.5.6.tgz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Looks like the skins/SMW_tooltip.js file is under a different LICENSE. (It's MIT). Also, there's only one file that says GPLv2 or later. So, I would say the License here should be: "GPL+ and GPLv2+ and MIT" 2. rpmlint says: mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza mediawiki116-semantic.noarch: E: incorrect-fsf-address /usr/share/doc/mediawiki116-semantic-1.5.6/COPYING mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza You might mail them about updating COPYING, others can be ignored. So, I think once the License is cleared up we are good to go.
(In reply to comment #2) > Issues: > > 1. Looks like the skins/SMW_tooltip.js file is under a different LICENSE. (It's > MIT). > Also, there's only one file that says GPLv2 or later. So, I would say the > License here > should be: "GPL+ and GPLv2+ and MIT" Great catch! I updated my local .spec and will upload corrected .spec and src.rpm files after resolving the following question. > 2. rpmlint says: > mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff > -> spin off, spin-off, Spinoza > mediawiki116-semantic.noarch: E: incorrect-fsf-address > /usr/share/doc/mediawiki116-semantic-1.5.6/COPYING > mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff -> > spin off, spin-off, Spinoza > > You might mail them about updating COPYING, others can be ignored. I mailed them when submitting the review request (see https://bugzilla.wikimedia.org/show_bug.cgi?id=29458). Upstream responded quickly and has already resolved the problem in svn. Would you like me to include the COPYING file from the upstream trunk branch as a patch, or continue with what is included in the release tarball?
Just use whats in the release until they update it in a new release... changing licensing stuff in a patch is not a good idea IMHO.
(In reply to comment #4) > Just use whats in the release until they update it in a new release... changing > licensing stuff in a patch is not a good idea IMHO. Sounds good. Release bumped and new .src and .spec uploaded with the changes discussed. Spec URL: http://jlaska.fedorapeople.org/rpms/mediawiki116-semantic.spec SRPM URL: http://jlaska.fedorapeople.org/rpms/mediawiki116-semantic-1.5.6-2.fc16.src.rpm fyi ... sourceforge seems down/slow at the moment so rpmlint's attempts to download the upstream tarball may fail.
Looks good. This package is APPROVED.
Setting fedora‑cvs=? New Package SCM Request ======================= Package Name: mediawiki116-semantic Short Description: An extension of MediaWiki that improves content organization Owners: jlaska Branches: f14 f15 el5 InitialCC:
Git done (by process-git-requests).
(In reply to comment #8) > Git done (by process-git-requests). Resetting fedora‑cvs=? Looks like I will need el6 also. Thank you! New Package SCM Request ======================= Package Name: mediawiki116-semantic Short Description: An extension of MediaWiki that improves content organization Owners: jlaska Branches: el5 el6 InitialCC:
Already exists in Fedora, but orphaned. https://admin.fedoraproject.org/pkgdb/acls/name/mediawiki116-semantic
(In reply to comment #10) > Already exists in Fedora, but orphaned. > > https://admin.fedoraproject.org/pkgdb/acls/name/mediawiki116-semantic Right, it's orphaned for rawhide and Fedora ... but needed for EPEL5 and EPEL6. I have a build+update for EPEL5 already. But it seems I need some git work to allow EPEL6 builds.
So request a Package Change, not New Package.
(In reply to comment #12) > So request a Package Change, not New Package. I believe I requested a SCM change, not a package review. The package review was already completed (see comment#6). The original SCM request (see comment#7) was handled in this bugzilla by using the fedora-cvs? flag. Since I need additional SCM help, I reset the fedora-cvs? flag. New Package SCM Request ======================= Package Name: mediawiki116-semantic Short Description: An extension of MediaWiki that improves content organization Owners: jlaska Branches: el5 el6 InitialCC: Apologies if this wasn't specific, or is not the proper venue.
(In reply to comment #12) > So request a Package Change, not New Package. Oh I see now ... is it the wording used in the template I cut'n'pasted? Would it suffice to ... s/New Package SCM Request/Package SCM Change Request/ Thanks!
No, it says new package. Try this: https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#Package_Change_Requests_for_existing_packages
The reason they need to follow the templates is that the tool we use to execute this parses them differently and do different things as a result.
(In reply to comment #16) > The reason they need to follow the templates is that the tool we use to execute > this parses them differently and do different things as a result. I understand now, thank you for clarifying, and apologies for any confusion. Package Change Request ====================== Package Name: mediawiki116-semantic New Branches: el6 Owners: jlaska
Git done (by process-git-requests). Perfect! No worries, sorry for the churn.
This is old and done long ago. ;)