Spec URL: http://ankursinha.fedorapeople.org/libtpcimgio/libtpcimgio.spec SRPM URL: http://ankursinha.fedorapeople.org/libtpcimgio/libtpcimgio-1.5.10-1.fc16.src.rpm Description: The libtpcimgio library is a collection of commonly used C files in Turku PET Centre for image file input and output procedures. Libtpcimgio library supports Analyze 7.5, Ecat 6.x, Ecat 7.x and partly interfile formats. ---------------------------------------------------------------------------- [ankur@ankur ~]$ rpmlint /tmp/mock-repo/libtpcimgio-* ~/rpmbuild/SPECS/libtpcimgio.spec libtpcimgio.i686: W: spelling-error Summary(en_US) Turku -> Turk, Turks, Turk u libtpcimgio.i686: W: no-documentation libtpcimgio.i686: W: no-manual-page-for-binary libtpcimgio libtpcimgio.src: W: spelling-error Summary(en_US) Turku -> Turk, Turks, Turk u libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/sif.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/img_ana.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/img_e63.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/ecat7r.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/analyze.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/ecat63p.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/img.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/libtpcimgiov.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/imgunit.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/ecat63w.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/img_e7.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/sifio.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/ecat7w.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/imgmax.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/ecat7ml.c libtpcimgio-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libtpcimgio/imgdecay.c libtpcimgio-devel.i686: W: no-documentation 4 packages and 1 specfiles checked; 16 errors, 5 warnings.
Ok, pretty much the same here as: https://bugzilla.redhat.com/show_bug.cgi?id=714326#c2 So I wont repeat myself. SPEC: http://hobbes1069.fedorapeople.org/libtpcimgio.spec Go ahead a make a new SRPM for both packages and I'll start going through the guideline checklist.
http://ankursinha.fedorapeople.org/libtpcimgio/libtpcimgio.spec http://ankursinha.fedorapeople.org/libtpcimgio/libtpcimgio-1.5.10-2.fc15.src.rpm Thanks! Ankur
Sorry, got busy but I'm back on the review! Richard
Ok, same thing with the BR's for graphviz, other than that I think we're good. Richard
hello, Added the BR http://ankursinha.fedorapeople.org/libtpcimgio/libtpcimgio.spec http://ankursinha.fedorapeople.org/libtpcimgio/libtpcimgio-1.5.10-3.fc15.src.rpm Thanks, Ankur
+: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output: shown in comment: No unexpected output [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: LGPLv2+ [+] license field matches the actual license. [N] license file is included in %doc: [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sums match: ced548015aae0c1f50827b6d51aade9c [+] package builds on at least one primary arch: Tested F14/F15 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [N] no relocatable packages [N] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [+] header files in -devel [+] static libraries in -static: In -devel with -static Provides [+] .so in -devel [+] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [N] query upstream for license text [N] description and summary contains available translations [+] package builds in mock [+] package builds on all supported arches [?] package functions as described: Did not test. [+] sane scriptlets [N] subpackages require the main package (other than -devel) [N] placement of pkgconfig files [N] file dependencies versus package dependencies [=] package contains man pages for binaries/scripts: *** APPROVED ***
Thank you for the review Richard :D New Package SCM Request ======================= Package Name: libtpcimgio Short Description: Turku PET Centre for image file input and output procedures Owners: ankursinha Branches: f14 f15 f16 InitialCC:
Git done (by process-git-requests).
libtpcimgio-1.5.10-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-3.fc15
libtpcimgio-1.5.10-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-3.fc16
libtpcimgio-1.5.10-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-3.fc14
Built and pushed to repos. Closing.
libtpcimgio-1.5.10-4.fc14, libtpcmisc-1.4.8-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-4.fc14,libtpcmisc-1.4.8-4.fc14
libtpcimgio-1.5.10-4.fc16, libtpcmisc-1.4.8-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-4.fc16,libtpcmisc-1.4.8-4.fc16
libtpcimgio-1.5.10-4.fc15, libtpcmisc-1.4.8-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-4.fc15,libtpcmisc-1.4.8-4.fc15
libtpcimgio-1.5.10-4.fc15, libtpcmisc-1.4.8-4.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
libtpcimgio-1.5.10-4.fc14, libtpcmisc-1.4.8-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
libtpcimgio-1.5.10-4.fc16, libtpcmisc-1.4.8-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.