Bug 715327
| Summary: | vdsm: cannot login to node when there are more them 190 targets in iscsi db | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Dafna Ron <dron> | ||||
| Component: | vdsm | Assignee: | Dan Kenigsberg <danken> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Dafna Ron <dron> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 6.1 | CC: | abaron, bazulay, coughlan, danken, dron, iheim, mchristi, yeylon, ykaul | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | storage | ||||||
| Fixed In Version: | vdsm-4.9-79 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | 715312 | Environment: | |||||
| Last Closed: | 2011-12-06 07:23:06 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 715312 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Dafna Ron
2011-06-22 14:35:57 UTC
after
/sbin/iscsiadm -m node -T Dafna-blonds-Linux -l -p 10.35.64.10:3260
fails, we return
Thread-1245::INFO::2011-06-22 12:33:11,455::dispatcher::100::Storage.Dispatcher.Protect::(run) Run and protect: connectStorageServer, Return response: {'status': {'message': 'OK', 'code': 0}, 'statuslist': [{'status': 459, 'id': 'e2a868c7-40a4-4168-a9f9-6e31b3f73d3d'}]}
where RemoveiSCSINodeError==459. That's unfortunate - we should return iSCSILoginError==464.
That's a minor bug, but its solution is interesting:
From dec3d671cafbcd5c783f94c6f6b1d33e5e40c430 Mon Sep 17 00:00:00 2001
From: Dan Kenigsberg <danken>
Date: Wed, 22 Jun 2011 23:19:57 +0300
Subject: [PATCH] BZ#715327 connectStorageServer: report original error
When connectStorageServer: fails, we try to clean after ourselves.
However, the error code we report should reflect the original cause of
the error, not a consequential error during cleanup.
Change-Id: I032ee0e059228559698bdd14b1dfe360885c6e35
---
vdsm/storage/iscsi.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/vdsm/storage/iscsi.py b/vdsm/storage/iscsi.py
index 59a7573..75f1542 100644
--- a/vdsm/storage/iscsi.py
+++ b/vdsm/storage/iscsi.py
@@ -18,6 +18,7 @@ import tempfile
import logging
import socket
import re
+import sys
import constants
import misc
@@ -471,6 +472,7 @@ def addiSCSINode(ip, port, iqn, tpgt, initiator, username=None, password=None):
if rc != 0:
raise se.iSCSILoginError(portal)
except se.StorageException:
+ exc_class, exc, tb = sys.exc_info()
try:
if checkSession(ip, port, iqn, tpgt, username, password):
return 0
@@ -482,7 +484,7 @@ def addiSCSINode(ip, port, iqn, tpgt, initiator, username=None, password=None):
except Exception:
log.error("Could not remove iscsi node", exc_info=True)
- raise
+ raise exc_class, exc, tb
def remiSCSINode(ip, port, iqn, tpgt, username=None, password=None, logout=True):
--
1.7.4.4
wasn't able to reproduce. verified for vdsm-4.9-81 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2011-1782.html |