Bug 715402 - [RFE] - run cryptographic tests as part of the nss-softokn build
Summary: [RFE] - run cryptographic tests as part of the nss-softokn build
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nss-softokn
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Elio Maldonado Batiz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-22 18:42 UTC by Elio Maldonado Batiz
Modified: 2012-03-13 22:10 UTC (History)
3 users (show)

Fixed In Version: nss-softokn-3.12.10-5.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-25 02:20:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Enables running the bltest suite as part of the build (117.47 KB, patch)
2011-06-22 18:44 UTC, Elio Maldonado Batiz
kengert: review+
Details | Diff
subset 1, the changes to the RPM scripts (6.76 KB, patch)
2011-07-13 15:45 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
subset 2, the included patch to NSS (109.81 KB, patch)
2011-07-13 15:45 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
subset 2, the included patch to NSS (fixed) (106.13 KB, patch)
2011-07-13 15:47 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
subset 2, the included patch to NSS (for real this time) (105.97 KB, patch)
2011-07-13 15:48 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff

Description Elio Maldonado Batiz 2011-06-22 18:42:37 UTC
Description of problem:
No tests are run with nss-softokn built. The crypto tests are run as part of the full test suite when nss is built. Now that softoken has been split into its own package we should run the relevant tests when we build the nss-softokn package

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
Build nss-softokn
  
Actual results:
No tests are run

Expected results:
some crypto-related test are run

Additional info:

Comment 1 Elio Maldonado Batiz 2011-06-22 18:44:47 UTC
Created attachment 506068 [details]
Enables running the bltest suite as part of the build

Comment 2 Elio Maldonado Batiz 2011-06-22 18:52:58 UTC
Comment on attachment 506068 [details]
Enables running the bltest suite as part of the build

The tests use the sectool static library for various services, among them error reporting, which brings dependencies on higher layers of nss. This patch includes a stripped-down version of the test utilities with such dependencies removed. This portion is temporary workaround until certain patches proposed upstream are approved and we upgrade.

Comment 3 Kai Engert (:kaie) (inactive account) 2011-07-13 15:43:34 UTC
I find the attached patch difficult to read, because most of it is a "diff of a patch".

I'm splitting it into two separate files, for easier reviewing, and I'll remove the initial "+" from the diffed patch.

Comment 4 Kai Engert (:kaie) (inactive account) 2011-07-13 15:45:12 UTC
Created attachment 512691 [details]
subset 1, the changes to the RPM scripts

Comment 5 Kai Engert (:kaie) (inactive account) 2011-07-13 15:45:34 UTC
Created attachment 512692 [details]
subset 2, the included patch to NSS

Comment 6 Kai Engert (:kaie) (inactive account) 2011-07-13 15:47:34 UTC
Created attachment 512693 [details]
subset 2, the included patch to NSS (fixed)

Comment 7 Kai Engert (:kaie) (inactive account) 2011-07-13 15:48:51 UTC
Created attachment 512694 [details]
subset 2, the included patch to NSS (for real this time)

Comment 8 Kai Engert (:kaie) (inactive account) 2011-07-13 15:54:39 UTC
Comment on attachment 512694 [details]
subset 2, the included patch to NSS (for real this time)

This patch is still somewhat tricky to review.

For example, secu_PrintRSAPublicKey is not removed, but the patch gives the impression that it's newly added.

It's sometimes helpful to use "diff --minimal" to try harder to detect deletions, which may have helped here.

Comment 9 Kai Engert (:kaie) (inactive account) 2011-07-13 16:03:40 UTC
Comment on attachment 512694 [details]
subset 2, the included patch to NSS (for real this time)

Despite not easy to know for sure from this patch, it appears, your code changes to NSS are limited to "removing code from NSS".

The interesting piece is at the end of the patch, where you modify the build scripts.

In "all.sh", you're modifying an existing comment. I would rather keep the original comment, and below it, I'd add something like this:

####################################################
# -- testing softokn module --
# This modified copy of all.sh builds a reduced set of directories.
# We check for the latest item being built.
# See variable DIRS in security/nss/cmd/manifest.mn
####################################################

Comment 10 Kai Engert (:kaie) (inactive account) 2011-07-13 16:05:00 UTC
Comment on attachment 506068 [details]
Enables running the bltest suite as part of the build

r=kaie

seems reasonable for your testing needs

Comment 11 Elio Maldonado Batiz 2011-07-13 16:18:13 UTC
Kai, My apologies for you having to deal for such a messy patch. I meant to replace with something cleaner that could be easily and cleanly applied and forgot to do it. I will incorporate your suggestion. Thanks the review!

Comment 12 Fedora Update System 2011-07-22 15:28:15 UTC
nss-softokn-3.12.10-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/nss-softokn-3.12.10-4.fc15

Comment 13 Fedora Update System 2011-07-23 01:56:35 UTC
Package nss-softokn-3.12.10-4.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nss-softokn-3.12.10-4.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/nss-softokn-3.12.10-4.fc15
then log in and leave karma (feedback).

Comment 14 Fedora Update System 2011-10-13 20:20:37 UTC
nss-softokn-3.12.10-5.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/nss-softokn-3.12.10-5.fc15

Comment 15 Fedora Update System 2011-10-15 20:28:53 UTC
Package nss-softokn-3.12.10-5.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nss-softokn-3.12.10-5.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-14415
then log in and leave karma (feedback).

Comment 16 Fedora Update System 2011-11-25 02:20:27 UTC
nss-softokn-3.12.10-5.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.