Red Hat Bugzilla – Bug 715404
Can create the same group over and over
Last modified: 2012-02-07 14:28:10 EST
Description of problem: Can create the same group over and over.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
2. Click New button
3. Create a new group with the same name as an existing group
There is no warning when the group is created a 2nd time that a group of the same name already exists.
A warning that a group of the same name already exists.
The expected behavior is not exactly intuitive or clear on creating a 2nd group of the same name. SHould it overwrite? SHould there be a warning that a group with that name already exists?
Found that in the source :
// GH: We are now allowing Groups where names collide... TODO, should this only be allowed for cluster auto backing groups?
(In reply to comment #1)
> Found that in the source :
> // GH: We are now allowing Groups where names collide... TODO, should this only
> be allowed for cluster auto backing groups?
ah.. right, this is to support our under-the-covers backing groups which could have the same name.
Created attachment 530449 [details]
(In reply to comment #3)
> Created attachment 530449 [details]
> Proposed patch
I am not comfortable with this solution. This actually seems to load every group in memory when you are in the group create wizard, and for users with very large numbers of groups, this may not be good.
I would prefer that we use a query that says, "given a group name G, is this already in use?". If the group exists, we should fail. If it doesn't exist, we can continue. If the problem is that the async nature doesn't easily allow for this in the wizard infrastructure, just have the Finish button collect the error thrown by the server side, we popup an error message saying, "A Group by that name already exists" and force the user to try again.
it is about the wizard infrastructure. I am totally comfortable by just displaying an error at the end.
e6d54f1 in master
Assigning to mike to qualify on master. When this is ok, he will assign back and I'll push it to the release branch.
verified in master 11/11/2011. OK to push to the jon 3.0 branch. changing status to ON_DEV and assigning to heiko.
a7d370d in release branch
okay ... this is fail-to-verify in jon 3 branch.
i myself tested this on master ... and saw the yellow warning on creating a group with the same name.
here on the jon 3 branch ... (just installed from https://hudson.qa.jboss.com/hudson/view/JON3%20Core/job/rhq-release-gwt-locales/7/ ) ... i can create a 2nd group with the same name. in fact ... the very same compat group named 'test' which i used in master ... i am using again in the jon 3 branch.
i don't get it.
attaching screenshot named "3groupswithsamename.png" which shows 3 groups with the very same name.
Created attachment 533165 [details]
3 groups with the same name
perhaps previous comment #10 did not include the fix.
i am seeing the correct behavior now in jon 3 branch.
changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE