Spec URL: http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter.spec SRPM URL: http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter-20110618-0.1svn5236.fc15.src.rpm Description: Elmer is an open source multiphysical simulation software developed by CSC - IT Center for Science (CSC). Elmer development was started 1995 in collaboration with Finnish Universities, research institutes and industry. Elmer includes physical models of fluid dynamics, structural mechanics, electromagnetics, heat transfer and acoustics, for example. These are described by partial differential equations which Elmer solves by the Finite Element Method (FEM).
http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter.spec http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter-20110623-0.1svn5244.fc15.src.rpm
http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter.spec http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter-0-0.1.20110807.svn5280.fc15.src.rpm
Please adapt the BR syntax according to the new ruling: http://fedoraproject.org/wiki/PackagingGuidelines#Requiring_Base_Package Drop "-n %{name}". Defattr is no longer necessary. Probably be a bit more specific in the files section. Also label the documentation as such. Installing via install -p -m 0644 AUTHORS ChangeLog COPYING NEWS README -t $RPM_BUILD_ROOT/%{_docdir}/hutiter/ and so on is wrong. Use the %doc macro. Is it possible to build shared libs? I'm not a hundred percent sure if the package is really GPLv2+. Do you have a statement somewhere?
The main elmer project is GPLv2+. These are just submodules required to build it. I was initially packaging them together in one spec but they need to be built before the main elmer software can be built. I'll go make the corrections. Thanks,, Ankur
Hi, I'm not working on -medical related packages anymore and will not be pursuing this review ticket. If someone else wishes to take up the review, please open a new ticket. Thanks, Ankur