Bug 715582 - qemu-kvm doesn't report error when supplied negative spice port value
Summary: qemu-kvm doesn't report error when supplied negative spice port value
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.2
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Gerd Hoffmann
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-23 12:42 UTC by Michal Haško
Modified: 2015-03-02 04:01 UTC (History)
7 users (show)

Fixed In Version: qemu-kvm-0.12.1.2-2.183.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 15:52:50 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:1531 0 normal SHIPPED_LIVE Moderate: qemu-kvm security, bug fix, and enhancement update 2011-12-06 01:23:30 UTC

Description Michal Haško 2011-06-23 12:42:21 UTC
Description of problem:
qemu-kvm doesn't show any error when user supplies a negative port value to -spice

Version-Release number of selected component (if applicable):
$ rpm -q qemu-kvm spice-server
qemu-kvm-0.12.1.2-2.165.el6.x86_64
spice-server-0.8.0-1.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. $ /usr/libexec/qemu-kvm -spice disable-ticketing,port=-3000
  
Actual results:
do_spice_init: starting 0.8.0
spice_server_add_interface: SPICE_INTERFACE_KEYBOARD
spice_server_add_interface: SPICE_INTERFACE_MOUSE
spice_server_add_interface: SPICE_INTERFACE_QXL
red_worker_main: begin
handle_dev_input: start

Expected results:
something like:
qemu-kvm: -spice disable-ticketing,port=-3000: Parameter 'port' expects a positive number
parse error: disable-ticketing,port=-3000

Comment 1 Michal Haško 2011-06-23 12:45:43 UTC
Happens as well when supplying a port that is out of range:

$ /usr/libexec/qemu-kvm -spice disable-ticketing,port=123456

Comment 3 Gerd Hoffmann 2011-07-14 15:03:36 UTC
Simliar to bug #717958, will have one patch for both.

Comment 9 Sibiao Luo 2011-08-16 10:08:30 UTC
I verify with the latest spice-server and qemu-kvm,but this issue doesn't
reproduce.

Version-Release number of selected component (if applicable):
# rpm -qa qemu-kvm spice-server
spice-server-0.8.2-3.el6.x86_64
qemu-kvm-0.12.1.2-2.183.el6.x86_64

Steps to Reproduce:
1.when supplying a port that is a negative value.
 # /usr/libexec/qemu-kvm -spice disable-ticketing,port=-30
Actual results:
spice port is out of range

2.when supplying a port that is out of range.
# /usr/libexec/qemu-kvm -spice disable-ticketing,port=123456
Actual results:
spice port is out of range

Above, the qemu-kvm has friendly error tips.

Comment 10 langfang 2011-08-26 02:04:53 UTC
Reproduced this issue with qemu-kvm-0.12.1.2-2.180.el6.x86_64,I tried two scenarios.

steps:
1. negative value
 # /usr/libexec/qemu-kvm -spice disable-ticketing,port=-30
2. port num out of range
 #/usr/libexec/qemu-kvm -spice disable-ticketing,port=123456

Result:
Qemu-kvm can be booted successful without any message about port error.

Verified this issue with fixed version qemu-kvm-0.12.1.2-2.184.el6.x86_64 using steps as same as reproduce.

Actual results:
--snip of output from qemu-kvm--
qemu-kvm can not be booted with friendly message "spice port is out of range".

Above all,this issue has been fixed.

Comment 12 errata-xmlrpc 2011-12-06 15:52:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html


Note You need to log in before you can comment on or make changes to this bug.