Bug 716563 - use make V=1
Summary: use make V=1
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: rawhide
Hardware: Unspecified
OS: Linux
low
low
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-24 21:49 UTC by Jan Kratochvil
Modified: 2011-08-10 17:36 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-10 17:36:52 UTC
Type: ---


Attachments (Terms of Use)

Description Jan Kratochvil 2011-06-24 21:49:17 UTC
Description of problem:
To reproduce a gcc bug I need full local rebuild to find out the compilation line.  rpm build.log could+should provide all the info.

Version-Release number of selected component (if applicable):
kernel-2.6.35.13-91.fc14.x86_64

How reproducible:
Always.

Steps to Reproduce:
wget -O - http://kojipkgs.fedoraproject.org/packages/kernel/2.6.35.13/91.fc14/data/logs/x86_64/build.log

Actual results:
Nothing seen.

Expected results:
Compilation lines seen.

Additional info:
The rpmbuild output is only useful to be stored into various log files anyway.

Comment 1 Jan Kratochvil 2011-06-24 21:50:55 UTC
In fact it is already there, it just does not work:
    make -s ARCH=$Arch V=1 %{?_smp_mflags} $MakeTarget %{?sparse_mflags}
->
+ make -s ARCH=x86_64 V=1 -j16 bzImage

Comment 2 Dave Jones 2011-07-05 22:49:31 UTC
my guess is that the build system isn't capturing stdout, just stderr ?

reassigning to koji to start, even though it might be some other part of the buildsys.

Comment 3 Jan Kratochvil 2011-07-06 08:12:08 UTC
s/make -s /make / fixes it as I found later.

Comment 4 Mike McLean 2011-07-06 13:52:25 UTC
It is mock that generates build.log, and it does capture stderr (see the do() function in mock/util.py). I suppose there could be a bug in python's subprocess module. Also rpmbuild (or some other process in the chain) could be killing stderr.

If nothing else captures it, then stderr will then be captured in mock_output.log by koji.

Your theory is easy to test. Just make some explicit writes to stderr in your spec and see if you get the output.

Comment 5 Jan Kratochvil 2011-07-06 13:58:50 UTC
As the problem+fix is reproducible with rpmbuild (Comment #3) i find Koji to be offtopic here.

Comment 6 Dave Jones 2011-07-06 18:03:30 UTC
oh, duh. yeah that'll do it.
I'll make the change in git.

Comment 7 Jarod Wilson 2011-07-06 19:19:12 UTC
I thought we were intentionally hiding make output so that warnings stood out. They get lost in the noise otherwise, unless you make all warnings fatal compile errors.

Comment 8 Jan Kratochvil 2011-07-06 19:49:30 UTC
It is dangerous to ship code with warnings.

Comment 9 Dave Jones 2011-07-06 19:51:13 UTC
with the rate that new warnings appear (and old ones stick around), I'm not sure it's that big a deal.  I think that most people don't read the build logs unless something fails.

We could add yet another magic variable to config this on or not, but I'm not sure it's really worth it.

Comment 10 Jan Kratochvil 2011-07-06 20:00:21 UTC
(In reply to comment #9)
> We could add yet another magic variable to config this on or not, but I'm not
> sure it's really worth it.

This Bug is request the default Fedora build.log files contain the flags.
New .spec flag not in use by default is not useful, I can remove "-s" in that case if I have to do a rebuild anyway.

This request is in direct conflict with Comment 7.

Comment 15 Josh Boyer 2011-08-01 17:28:49 UTC
We're going to close this as wontfix.  Those needing to fix warnings or determine the build flags are likely already doing local builds anyway.  For the rest of people, it just grows the build logs unnecessarily.

Comment 16 Jan Kratochvil 2011-08-01 17:38:55 UTC
(In reply to comment #15)
> Those needing to fix warnings or
> determine the build flags are likely already doing local builds anyway.

FYI Comment 13 explains why this is not applicable.

Comment 17 Jan Kratochvil 2011-08-10 17:20:27 UTC
Reopening as this behavior is now decided as global Fedora policy.

[PATCH] macros: Globally add --disable-silent-rules to configure
http://lists.fedoraproject.org/pipermail/devel/2011-August/155444.html
redhat-rpm-config-9.1.0-16.fc17
* Wed Aug 10 2011 Colin Walters <walters> - 9.1.0-16
- Globally disable silent rules

Comment 18 Adam Jackson 2011-08-10 17:36:52 UTC
Re-closing as this is still painfully excessive for the kernel.


Note You need to log in before you can comment on or make changes to this bug.