Spec URL: https://raw.github.com/remicollet/remirepo/master/perl-FusionInventory-Agent-Task-SNMPQuery/perl-FusionInventory-Agent-Task-SNMPQuery.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.remi.src.rpm Description: SNMP Query support for FusionInventory Agent
Another trivial review perl-FusionInventory-Agent-Task-SNMPQuery (Perl package) MUST: rpmlint must be run on src.rpm and rpm. OK $ rpmlint -iv perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc17.src.rpm perl-FusionInventory-Agent-Task-SNMPQuery.src: I: checking perl-FusionInventory-Agent-Task-SNMPQuery.src: I: checking-url http://forge.fusioninventory.org/projects/fusioninventory-agent-task-snmpquery (timeout 10 seconds) perl-FusionInventory-Agent-Task-SNMPQuery.src: I: checking-url http://search.cpan.org/CPAN/authors/id/F/FU/FUSINV/FusionInventory-Agent-Task-SNMPQuery-1.3.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -iv perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc17.noarch.rpm perl-FusionInventory-Agent-Task-SNMPQuery.noarch: I: checking perl-FusionInventory-Agent-Task-SNMPQuery.noarch: I: checking-url http://forge.fusioninventory.org/projects/fusioninventory-agent-task-snmpquery (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. MUST: package named accordingly to package naming guidelines. OK MUST: spec file name match %{name} OK MUST: package meets packaging guidelines OK MUST: package must be licensed under a fedora-compliant license OK (GPLv2+) MUST: License field in package spec match actual license OK License file included and distributed MUST: spec in legible american english OK MUST: sources provided match upstream's OK provided sources sha1sum: 2fe44c328879f55f5c49c2a69749d35a77bd404a upstream sources sha1sum: 2fe44c328879f55f5c49c2a69749d35a77bd404a MUST: package successfully compiles on at least one primary architecture OK (all of them) MUST: all build dependencies are listed in BR OK MUST: package must own all directories it creates OK MUST: package does not list a file more than once in %files section OK MUST: permissions are properly set OK MUST: package consistenly use macros OK MUST: package contains permissable content OK MUST: package does not own directories owned by other packages OK MUST: all filenames in package are valid UTF-8 OK SHOULD: mock builds were done on rawhide on all primary architectures (x86/x86_64) OK SHOULD: man pages are provided OK This package respects general & Perl Fedora Packaging guidelines, so i hereby approve this package into Fedora Packages Collection
Thanks for the review :) New Package SCM Request ======================= Package Name: perl-FusionInventory-Agent-Task-SNMPQuery Short Description: SNMP Query support for FusionInventory Agent Owners: remi Branches: f14 f15 f16 el6 InitialCC:
Git done (by process-git-requests). Haikel, in the future, please take ownership of review bugs you're working on. Thanks!
fusioninventory-agent-2.1.9-3.fc16,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fusioninventory-agent-2.1.9-3.fc16,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16
fusioninventory-agent-2.1.9-3.fc15,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc15,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc15,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc15,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fusioninventory-agent-2.1.9-3.fc15,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc15,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc15,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc15,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc15
fusioninventory-agent-2.1.9-3.fc14,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc14,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc14,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc14,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/fusioninventory-agent-2.1.9-3.fc14,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc14,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc14,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc14,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc14
fusioninventory-agent-2.1.9-3.fc16, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16 has been pushed to the Fedora 16 testing repository.
fusioninventory-agent-2.1.9-3.fc14, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc14, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc14, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc14, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc14 has been pushed to the Fedora 14 stable repository.
fusioninventory-agent-2.1.9-3.fc15, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc15, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc15, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc15, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc15 has been pushed to the Fedora 15 stable repository.
fusioninventory-agent-2.1.9-3.fc16, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16 has been pushed to the Fedora 16 stable repository.