RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 718293 - igb: failed to activate WOL on 2nd LAN port on i350
Summary: igb: failed to activate WOL on 2nd LAN port on i350
Keywords:
Status: CLOSED DUPLICATE of bug 694211
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.1
Hardware: x86_64
OS: Linux
urgent
high
Target Milestone: rc
: ---
Assignee: Stefan Assmann
QA Contact: Network QE
URL:
Whiteboard:
Depends On:
Blocks: 697489 718988 727128 743807
TreeView+ depends on / blocked
 
Reported: 2011-07-01 17:42 UTC by Martin Wilck
Modified: 2011-11-23 15:35 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Some system vendors desired the Wake-on-Lan capability to be accessible on more than the first on-board port of an Intel i350 network adapter. Due to a bug in the igb driver, this was not possible. This bug has been fixed and igb now honors the EEPROM setting for the second port.
Clone Of:
: 718988 (view as bug list)
Environment:
Last Closed: 2011-09-07 19:10:45 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
sosreport (1.39 MB, application/x-xz)
2011-07-01 17:43 UTC, Martin Wilck 		no flags Details
proposed patch (526 bytes, patch)
2011-07-04 11:44 UTC, Martin Wilck 		no flags Details | Diff
View All

Description Martin Wilck 2011-07-01 17:42:45 UTC 
Description of problem:
On a PRIMERGY RX300S7 (Romley/Patsburg system with onboard Powerville NIC), wake-on-lan can't be activated with the RHEL6.1 native igb driver 3.0.6-k2.

Version-Release number of selected component (if applicable):

2.6.32-131.0.15.el6.x86_64, igb 3.0.6-k2

How reproducible:
always

Steps to Reproduce:
1. run "ethtool eth2"

Actual results:
Supports Wake-on: d

Expected results:
Supports Wake-on: pumbg

Additional info:
The driver igb 3.0.19 from e1000.sourceforge.net enables WOL on this port successfully.
Comment 1 Martin Wilck 2011-07-01 17:43:42 UTC 
Created attachment 510903 [details]
sosreport
Comment 3 Martin Wilck 2011-07-01 18:33:49 UTC 
The weird thing is that I can see no difference in the WOL logic between igb 3.0.6-k2 and igb 3.0.19.

Mainly the driver looks at certain bit in the EEPROM (NVM_INIT_CONTROL3_PORT_A = 24 for Port A and NVM_INIT_CONTROL3_PORT_B = 14 for port B, bitmask 0x400). The eeprom registers are 16bit wide and indexing is also by 16-but words.

I checked the eeprom settings and they are the same for both drivers.

0x0000          00 19 99 7e fc 63 00 08 ff ff 30 09 ff ff ff ff
0x0010          31 31 35 30 2f 60 ce 11 34 17 21 15 86 80 a7 b3
0x0020          ff ff ff ff 80 60 81 00 6d eb 50 00 00 4c 17 0a
0x0030          bf 3d 00 70 0a 1a 26 34 83 07 a6 10 00 02 02 06
0x0040          04 00 47 25 00 00 ff ff 81 04 f1 01 20 15 79 0f
0x0050          80 1c 1c 00 00 00 04 14 00 00 00 00 00 10 ff ff

        register 14 (offset 28, control port B) is eb6d -> WOL off !
        register 24 (offset 48, control port A) is 0481 -> WOL on !

This would suggest that the 3.0.19 driver somehow enables WOL on port B although it is disabled in the FW. But perhaps I got something wrong with the registers offsets. I need to check this again.
Comment 4 Martin Wilck 2011-07-01 18:35:04 UTC 
Please have Intel engineers check this problem and my assessment.
Comment 5 Martin Wilck 2011-07-04 11:44:14 UTC 
Created attachment 511175 [details]
proposed patch

I think I found the difference between the OEM and upstream drivers. It's a trivial patch. Intel, please verify.
Comment 6 Martin Wilck 2011-07-04 14:19:20 UTC 
Verified that the patch in comment #5 indeed solves the problem.
Comment 7 Martin Wilck 2011-07-04 14:24:38 UTC 
We request a 6.1.z errata with the patch from comment #5. I also just posted this patch upstream to netdev.org.
Comment 8 Martin Wilck 2011-07-05 08:24:10 UTC 
Upstream submission here:

http://marc.info/?l=linux-netdev&m=130978970530745&w=2
Comment 9 carolyn.wyborny 2011-07-06 15:04:24 UTC 
Yes, I agree with the fix.  Thanks for the catch.  Will ack the upstream patch.
Comment 10 Martin Wilck 2011-07-08 12:19:04 UTC 
Stefan, please initiate a 6.1.z release. Given Carolyn's ACK and the simplicity of the patch, that shouldn't be a big problem any more.
Comment 11 Stefan Assmann 2011-07-11 07:04:42 UTC 
The patch needs to go into 6.2 first and can be backported to 6.1.z afterwards.
Comment 12 Martin Wilck 2011-07-11 07:18:46 UTC 
OK, add it to 6.2, please. Do you expect me to open a new BZ?
Comment 13 Stefan Assmann 2011-07-11 07:51:46 UTC 
No, I'll make sure it is proposed for 6.1.z. Thanks for your work Martin.
Comment 14 RHEL Program Management 2011-07-11 07:59:58 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.
Comment 15 Stefan Assmann 2011-07-25 10:26:23 UTC 
The fix will be provided as part of the RHEl6.2 igb driver update (#694211).
Comment 16 Larry Troan 2011-07-28 13:38:27 UTC 
Opening Stefan's comment above to Martin.

So do we use this bug for the 6.1.z stream request or clone it first and close this bug as a DUP of bug 694211?
Comment 17 Martin Wilck 2011-07-28 15:31:25 UTC 
As noted elsewhere, we agree with Stefan that backporting the 6.2 driver into 6.1.z is not a good idea. We'd rather propose to release a 6.1.z with just the patch from comment #8 applied.
Comment 18 Stefan Assmann 2011-08-03 12:56:10 UTC 
Larry,
for the sake of trackability please clone and mark this as DUP. Thanks!
Comment 19 Martin Wilck 2011-09-05 13:56:44 UTC 
Hmm, there's a test kernel for 5.8 available now on bug #718988. I'd rather retest for RHEL6.x because that's where the bug was originally reported.
Comment 20 Peter Martuccelli 2011-09-07 19:10:45 UTC 

*** This bug has been marked as a duplicate of bug 694211 ***
Comment 23 Tomas Capek 2011-11-23 15:35:47 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Some system vendors desired the Wake-on-Lan capability to be accessible on more than the first on-board port of an Intel i350 network adapter. Due to a bug in the igb driver, this was not possible. This bug has been fixed and igb now honors the EEPROM setting for the second port.
Note You need to log in before you can comment on or make changes to this bug.