Spec URL: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac.spec SRPM URL: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac-0.4.0-1.fc14.src.rpm Description: This module provides common interface to HMAC functionality. HMAC is a kind of "Message Authentication Code" (MAC) algorithm whose standard is documented in RFC2104. Namely, a MAC provides a way to check the integrity of information transmitted over or stored in an unreliable medium, based on a secret key. Originally written by Daiki Ueno. Converted to a RubyGem by Geoffrey Grosenbach [clalance@localhost SPECS]$ rpmlint rubygem-hmac.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [clalance@localhost SPECS]$ rpmlint ../SRPMS/rubygem-hmac-0.4.0-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Taking this one
Overall looks good, koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199493 A few specific nuances though: - please replace all the %defines at the top w/ %globals http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - please enable --ri documentaion on the gem install command - lib/hmac.rb is licensed under the ruby license and thus the package license must be set to MIT and Ruby accordingly - please mark the test directory as %doc - since the test directory is included, it wouldn't be a bad idea to include a %check section to run the suite - you need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby as instructed here http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines
(In reply to comment #2) > Overall looks good, koji build is green: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=3199493 > > A few specific nuances though: > > - please replace all the %defines at the top w/ %globals > > http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define Oops, fixed. > > > - please enable --ri documentaion on the gem install command Done, but the use of --ri is very inconsistent in Fedora. Many packages don't have it, but some do. > > - lib/hmac.rb is licensed under the ruby license and thus the package license > must be set to MIT and Ruby accordingly Fixed. > > - please mark the test directory as %doc Fixed. > > - since the test directory is included, it wouldn't be a bad idea to include a > %check section to run the suite Fixed. > > - you need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby as instructed > here > > http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines Done. New SRPM: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac-0.4.0-2.fc14.src.rpm New SPEC: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac.spec
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: rubygem-hmac Short Description: This module provides common interface to HMAC functionality Owners: clalance mmorsi
Git done (by process-git-requests).