Created attachment 511731 [details]
Patch to fix the described behavior

Description of problem:

When authenticating via LDAP, pulp first tries to check a local user.  But if there is no local saved password, then pulp.server.auth.password_util.check_password() can't split() the saved password, and a stack trace obtains.

Version-Release number of selected component (if applicable):

0.0.202, HEAD

How reproducible:

Every time.

Steps to Reproduce:

1. Configure pulp for LDAP authn
2. Try to authenticate as an LDAP user without a local password.
  
Actual results:

File "/usr/lib/python2.4/site-packages/pulp/server/webservices/controllers/decorators.py", line 48, in report_error
    return method(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/pulp/server/webservices/controllers/decorators.py", line 89, in _auth_decorator
    user = check_username_password(username, password)
  File "/usr/lib/python2.4/site-packages/pulp/server/auth/authentication.py", line 128, in check_username_password
    user = _check_username_password_local(username, password)
  File "/usr/lib/python2.4/site-packages/pulp/server/auth/authentication.py", line 111, in _check_username_password_local
    if not check_password(user[\'password\'], password):
  File "/usr/lib/python2.4/site-packages/pulp/server/auth/password_util.py", line 47, in check_password
    salt, hashed_password = saved_password_entry.split(",")

Expected results:

Local authn should fail silently, and LDAP authn should be attempted.

Additional info:

Patch attached.  Since check_password() requires a string for its first argument (the password), _check_username_password_local() can no longer be called without a second argument (the password), which was defaulting to None.  My patch makes _check_username_password_local() require two arguments, and check_username_password() will only call it if there's a local password.