Spec URL: http://kumarpraveen.fedorapeople.org/django-followit/django-followit.spec SRPM URL: http://kumarpraveen.fedorapeople.org/django-followit/django-followit-0.0.1-1.20110709gitb53320.fc15.src.rpm Description: The django-followit django app allows to easily set up a capability for the site users to follow various things on the site, represented by django model objects.
[X] Package name - ok. [X] Package group - ok. [X] Package license: BSD - ok. [X] Build successful - ok. [X] rpmlint SRPMS/django-followit-0.0.1-1.20110709gitb53320.fc14.src.rpm django-followit.src: W: invalid-url Source0: django-followit-0.0.1.20110709gitb53320.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - ok(source is pulled from git repository). [X] rpmlint RPMS/noarch/django-followit-0.0.1-1.20110709gitb53320.fc14.noarch.rpm django-followit.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - %doc section needs documents. [X] Install/Un-install - ok. Overall good. Please supply some documentation in %doc LICENSE README ...
Source is only contain a zero-size README.txt so should I remove doc section ?
Removing %doc does not sound like a good idea. May be you could write a README explaining what the package is about and how it is useful. You could also include LICNESE file in %doc.
Added license file. Updated spec : http://kumarpraveen.fedorapeople.org/django-followit/django-followit.spec Update srpm : http://kumarpraveen.fedorapeople.org/django-followit/django-followit-0.0.1-2.20110717git15ced1.fc15.src.rpm koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3205158
[X] Package name - ok [X] Pacakge group - ok. [X] Package license - ok. [X] Build successful - ok. [X] pmlint SRPMS/django-followit-0.0.1-2.20110717git15ced1.fc14.src.rpm django-followit.src: W: invalid-url Source0: django-followit-0.0.1.20110717git15ced1.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - ok. [X] rpmlint RPMS/noarch/django-followit-0.0.1-2.20110717git15ced1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - ok. [X] Install/Un-install - ok. [root]# rpm -ivh django-followit-0.0.1-2.20110717git15ced1.fc14.noarch.rpm Preparing... ########################################### [100%] 1:django-followit ########################################### [100%] [root]# rpm -ev django-followit-0.0.1-2.20110717git15ced1.fc14 [root]# rpm -qa | grep django-followit Overall good.
Approved.
New Package SCM Request ======================= Package Name: django-followit Short Description: A django app that allows users to follow django model objects Owners: kumarpraveen Branches: f14 f15
django-followit is now in pypi, has a release tarball and the license included in this tarball. You should update your spec for using this url and the tarball there http://pypi.python.org/pypi/followit/ Also instead of mv, you could use %doc followit/LICENSE or define a macro, %global srcname followit and then using that macro consistently throughout the spec.
Also add PKG-INFO to %doc
Done SPEC url : http://kumarpraveen.fedorapeople.org/django-followit/django-followit.spec SRPM url : http://kumarpraveen.fedorapeople.org/django-followit/django-followit-0.0.2-3.fc15.src.rpm koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3205985
New Package SCM Request ======================= Package Name: django-followit Short Description: A django app that allows users to follow django model objects Owners: kumarpraveen sundaram pjp Branches: f14 f15 el6
Git done (by process-git-requests).