Bug 720327 - Review Request: perl-DynaLoader-Functions - Deconstructed dynamic C library loading
Summary: Review Request: perl-DynaLoader-Functions - Deconstructed dynamic C library l...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 720323
Blocks: 720333
TreeView+ depends on / blocked
 
Reported: 2011-07-11 12:01 UTC by Petr Pisar
Modified: 2011-09-27 23:03 UTC (History)
2 users (show)

Fixed In Version: perl-DynaLoader-Functions-0.000-1.fc15
Clone Of:
Environment:
Last Closed: 2011-09-27 22:57:27 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-07-11 12:01:55 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-DynaLoader-Functions/perl-DynaLoader-Functions.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-DynaLoader-Functions/perl-DynaLoader-Functions-0.000-1.fc15.src.rpm
Description:
This module provides a function-based interface to dynamic loading as used
by Perl. Some details of dynamic loading are very platform-dependent, so
correct use of these functions requires the programmer to be mindful of the
space of platform variations.


----
Notice for packager: Target to F16--14 due to perl-smartmatch.

Comment 1 Marcela Mašláňová 2011-07-20 12:40:52 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides rpmbuild/RPMS/noarch/perl-DynaLoader-Functions-0.000-1.fc16.noarch.rpm 
perl(DynaLoader::Functions) = 0.000
perl-DynaLoader-Functions = 0.000-1.fc16

rpm -qp --requires rpmbuild/RPMS/noarch/perl-DynaLoader-Functions-0.000-1.fc16.noarch.rpm 
perl(:MODULE_COMPAT_5.12.3)  
perl(Carp)  
perl(DynaLoader)  
perl(Exporter)  
perl(Module::Runtime) >= 0.007
perl(Params::Classify) >= 0.008
perl(parent)  
perl(strict)  
perl(warnings)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

This package is conditionally approved, because build requires is not in buildroot yet. Check if it builds in koji first. It does build for me in local rawhide.
APPROVED

Comment 2 Petr Pisar 2011-07-20 14:52:36 UTC
New Package SCM Request
=======================
Package Name: perl-DynaLoader-Functions 
Short Description: Deconstructed dynamic C library loading
Owners: ppisar mmaslano psabata
Branches: f14 f15
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2011-07-20 15:47:45 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2011-07-21 08:02:44 UTC
Thank you for the review and the repository.

Comment 5 Fedora Update System 2011-09-19 09:38:11 UTC
perl-DynaLoader-Functions-0.000-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-DynaLoader-Functions-0.000-1.fc15

Comment 6 Fedora Update System 2011-09-19 09:38:46 UTC
perl-DynaLoader-Functions-0.000-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-DynaLoader-Functions-0.000-1.fc14

Comment 7 Fedora Update System 2011-09-19 22:56:22 UTC
perl-DynaLoader-Functions-0.000-1.fc14, perl-Devel-CallChecker-0.003-1.fc14 has been pushed to the Fedora 14 testing repository.

Comment 8 Fedora Update System 2011-09-27 22:57:16 UTC
perl-DynaLoader-Functions-0.000-1.fc14, perl-Devel-CallChecker-0.003-1.fc14 has been pushed to the Fedora 14 stable repository.

Comment 9 Fedora Update System 2011-09-27 23:03:39 UTC
perl-DynaLoader-Functions-0.000-1.fc15, perl-Devel-CallChecker-0.003-1.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.