Spec URL: http://ppisar.fedorapeople.org/perl-smartmatch-engine-core/perl-smartmatch-engine-core.spec SRPM URL: http://ppisar.fedorapeople.org/perl-smartmatch-engine-core/perl-smartmatch-engine-core-0.02-1.fc15.src.rpm Description: This module implements the existing smart matching algorithm from perl 5.14, as a module. It has a pure perl implementation of the algorithm (which can be requested by setting $smartmatch::engine::core::USE_PP to a true value before "use"-ing this engine), but by default it uses a C implementation which should be identical to the algorithm in 5.14 - this module uses some new compiler hooks to turn calls to the engine's "match" function into a custom op-code, which is implemented by a copy of the smart match code from perl 5.14. ---- Notice for packager: Target to F16--14 due to perl-smartmatch.
I guess upstream didn't update for perl 5.14.2. In file included from core.xs:7:0: stolen_chunk_of_pp_ctl.c: In function 'S_matcher_matches_sv': stolen_chunk_of_pp_ctl.c:62:5: warning: implicit declaration of function 'Perl_pp_match' [-Wimplicit-function-declaration] stolen_chunk_of_pp_ctl.c: In function 'S_do_smartmatch': stolen_chunk_of_pp_ctl.c:541:6: warning: implicit declaration of function 'Perl_pp_i_eq' [-Wimplicit-function-declaration] stolen_chunk_of_pp_ctl.c:543:6: warning: implicit declaration of function 'Perl_pp_eq' [-Wimplicit-function-declaration] stolen_chunk_of_pp_ctl.c:555:5: warning: implicit declaration of function 'Perl_pp_seq' [-Wimplicit-function-declaration] stolen_chunk_of_pp_ctl.c:555:5: warning: return makes pointer from integer without a cast [enabled by default] In file included from core.xs:9:0: callchecker0.h: At top level: callchecker0.h:7:3: error: #error this callchecker0.h is for Perl 5.14.1 only make: *** [core.o] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.Iax5E8 (%build)
This check is generated by perl-Devel-CallChecker which stores Perl version at its compile time: lib/Devel/CallChecker.xs: "#ifndef PERL_VERSION\n" " #error you must include perl.h before callchecker0.h\n" "#elif !(PERL_REVISION == "STRINGIFY(PERL_REVISION)" && " "PERL_VERSION == "STRINGIFY(PERL_VERSION)" && " "PERL_SUBVERSION == "STRINGIFY(PERL_SUBVERSION)")\n" " #error this callchecker0.h is for " "Perl "PERL_VERSION_STRING" only\n" "#endif /* Perl version mismatch */\n" We need to rebuild perl-Devel-CallChecker on each Perl version change.
perl-Devel-CallChecker has been rebuilt. This package build in F17 now.
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [!]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [-]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [!]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint output is silent. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/contyk/src/review/720339/smartmatch-engine-core-0.02-TRIAL.tar.gz : MD5SUM this package : ee936646804a609e0e32a3e15f98a390 MD5SUM upstream package : ee936646804a609e0e32a3e15f98a390 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [-]: SHOULD Spec use %global instead of %define. Issues: TODO: BuildRequire perl(Carp) TODO: BuildRequire perl(File::Temp) Generated by fedora-review 0.1.1 External plugins:
Yeah, some packages have changed since F15. Updated package: Spec URL: http://ppisar.fedorapeople.org/perl-smartmatch-engine-core/perl-smartmatch-engine-core.spec SRPM URL: http://ppisar.fedorapeople.org/perl-smartmatch-engine-core/perl-smartmatch-engine-core-0.02-1.fc17.src.rpm
--- a/perl-smartmatch-engine-core.spec +++ b/perl-smartmatch-engine-core.spec @@ -10,7 +10,9 @@ Source0: http://search.cpan.org/CPAN/authors/id/D/DO/DOY/smar BuildRequires: perl(Devel::CallChecker) BuildRequires: perl(ExtUtils::MakeMaker) # Tests: +BuildRequires: perl(Carp) BuildRequires: perl(Hash::Util::FieldHash) +BuildRequires: perl(File::Temp) BuildRequires: perl(smartmatch) >= 0.03 BuildRequires: perl(Scalar::Util) BuildRequires: perl(Test::More) >= 0.88 Approving.
New Package SCM Request ======================= Package Name: perl-smartmatch-engine-core Short Description: Default smartmatch implementation from 5.10---5.14 Owners: ppisar mmaslano psabata Branches: f15 f16 InitialCC: perl-sig
Git done (by process-git-requests).
Thank you for the review and the repository.
This has been in stable branches for quite some time now.