Bug 720432 - Close button for change set filter out of place
Summary: Close button for change set filter out of place
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Eric Helms
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On:
Blocks: katello-blockers
TreeView+ depends on / blocked
 
Reported: 2011-07-11 15:49 UTC by Jeff Weiss
Modified: 2019-09-26 13:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-22 17:49:29 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (16.19 KB, image/png)
2011-07-11 15:49 UTC, Jeff Weiss
no flags Details

Description Jeff Weiss 2011-07-11 15:49:02 UTC
Description of problem:
See attached screenshot.  The "X" in the shaded area closes the filter bar, but it should be inside the filter bar.  

Version-Release number of selected component (if applicable):
katello-0.1.49-1.git.351.4aac21a.fc14.noarch

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jeff Weiss 2011-07-11 15:49:32 UTC
Created attachment 512250 [details]
screenshot

Comment 2 Eric Helms 2011-07-25 15:35:09 UTC
When you say inside the filter bar - do you mean up next to the search button itself?  The current mockups have the "x" that closes the filter bar area in the location it currently resides.  Or did you mean the "x" more beside the filter bar, perhaps to the immediate right?  I would think people might accidentally click close or search if they are too close next too one another.

Comment 3 Jeff Weiss 2011-09-19 19:40:12 UTC
I don't mean to question the mockup, but I have never seen a "X" close button that is outside the thing it closes.  That's like putting a gnome window close button on the desktop.  It doesn't make sense because you have no idea what will happen when you click it - will it close a window or the whole desktop or what?

Same here, for all a user knows, that X closes the entire right panel.

I think the x needs to be inside that blue rounded square surrounding the search bar.  Doesn't matter to me if it's on the right or left.  The filter bar is plenty wide if you ask me - can put some space on the right between the search icon and the x.

Also, please don't mark bugs MODIFIED unless there is a commit.  If you need info, leave in the NEW or ASSIGNED state and add a NEEDINFO ("Need additional information from" checkbox)

Comment 4 Jeff Weiss 2011-09-19 19:40:39 UTC
This bug sat untouched for 2 months because it was in the wrong state.

Comment 5 Eric Helms 2011-10-13 13:59:06 UTC
commit c497449ab94fffd58b4c552468b38cf2342e46cd

The 'x' has been moved up to be beside the filter in the same vertical spot as the search button across all the places where the sliding tree filter is used.  The search icon was kept inside the input box with the x just to the right of it to help indicate closing the filter box.

Comment 6 Jeff Weiss 2011-10-24 15:05:26 UTC
UI is as described in the previous comment.  katello-0.1.95-1.git.56.344ea38.el6.x86_64  Verified

Comment 9 Mike McCune 2013-08-16 17:55:59 UTC
getting rid of 6.0.0 version since that doesn't exist


Note You need to log in before you can comment on or make changes to this bug.