Bug 722324 - Legacy sysv init scripts should be packed seperatly or dropped
Summary: Legacy sysv init scripts should be packed seperatly or dropped
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dovecot
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Hlavinka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: SysVtoSystemd
TreeView+ depends on / blocked
 
Reported: 2011-07-14 21:46 UTC by Jóhann B. Guðmundsson
Modified: 2011-07-15 11:04 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-15 11:04:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jóhann B. Guðmundsson 2011-07-14 21:46:40 UTC
Description of problem:

Please read the following ( Now available and official ;) ) and package dovecot according to the Fedora Packaging Guidelines.

https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
https://fedoraproject.org/wiki/Packaging:Tmpfiles.d



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Michal Hlavinka 2011-07-15 07:22:59 UTC
Well... this bug description is pretty useless, because it's too vague.

Anyway, 
- dovecot uses systemd for a long time now
- dovecot has systemd scripts in spec file that work and are well tested (not sure if it's exactly as packaging recommends - it was not available those days)
- dovecot uses tmpfiles.d

so from "bug description" I don't see any problem

and dovecot rpm does not contain sysv init script, so bug summary is not valid too.

Did you use correct component?

Comment 2 Jóhann B. Guðmundsson 2011-07-15 10:00:30 UTC
http://koji.fedoraproject.org/koji/rpminfo?rpmID=2544842 <--- shows /etc/rc.d/init.d/dovecot which should either be dropped or package separately according to the packagaging guidelines...

"SysV Initscripts
Packages may also provide a SysV initscript file, but are not required to do so. This format is considered legacy, but Fedora still contains init mechanisms such as upstart which do not support the systemd unit file format. If present, the SysV initscript(s) must go into an optional subpackage, so as not to confuse sysadmins. The guidelines for SysV initscripts can be found here: Packaging:SysVInitScript"

Comment 3 Michal Hlavinka 2011-07-15 11:04:12 UTC
interesting, fix is in git since May 30th, but there was no build since. Building now


Note You need to log in before you can comment on or make changes to this bug.