Spec URL: http://jjmcd.fedorapeople.org/Download/R-qcc.spec SRPM URL: http://jjmcd.fedorapeople.org/Download/R-qcc-2.0.1-1.fc15.src.rpm Description: An R package for quality control charting and statistical process control. The qcc package for the R statistical environment provides: - Plot Shewhart quality control charts - Plot Cusum and EMWA charts for continuous data - Draw operating characteristic curves - Perform process capability analysis - Draw Pareto charts and cause-and-effect diagrams
* Latest version packaged Target is already in the folder, no need to re-download it 6d739af03ac690f15b08ac91816951f6360d2464 qcc_2.0.1.tar.gz 6d739af03ac690f15b08ac91816951f6360d2464 ~/rpmbuild/SOURCES/qcc_2.0.1.tar.gz * sha1sum are equals ! Not all mandatory Requires are present, missing ['R-core'] * All required BuildRequires are present * The macro %check is present * There is 1 %dir %dir is OK * There is 3 %doc * More element than expected in %doc (CITATION has been added) * The rpm installed in _datadir * The rpm uses %{_datadir} and is noarch * The rpm seems to have the required element in %install * Build properly under 2.6.35.14-95.fc14.x86_64 Logs are clean. * rpmlint: R-qcc.noarch: E: incorrect-fsf-address /usr/share/R/library/qcc/COPYING R-qcc.noarch: W: wrong-file-end-of-line-encoding /usr/share/R/library/qcc/CITATION R-qcc.noarch: W: one-line-command-in-%post /usr/lib/rpm/R-make-search-index.sh R-qcc.noarch: W: one-line-command-in-%postun /usr/lib/rpm/R-make-search-index.sh 2 packages and 0 specfiles checked; 1 errors, 3 warnings. You can correct all of them. * Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3327296 0 free 0 open 2 done 0 failed 3327296 build (f16, R-qcc-2.0.1-1.fc15.src.rpm) completed successfully Additionally: You may want to check http://fedoraproject.org/wiki/Packaging:R as the template has changed a little bit. > Requires(post): R > Requires(postun): R > ... > %post > %{_R_make_search_index} > %postun > %{_R_make_search_index} These lines are not needed anymore. > Requires: R This should be R-core (as mentioned above) Regarding the license: - GPLv2+ is a valid license for Fedora and consistently used in the sources. - Could you check with upstream if they/we are allowed to redistribute the files: qcc/inst/doc/qcc_Rnews.pdf (article from the R news paper) qcc/demo/process.variation.R (seem to come from a book)
ping ?
Sorry - should have at least noted that I heard. I appreciate your effort to review this. It is in my queue, but my queue is pretty long. I need to focus on Release Notes (and some non-Fedora things) before I turn my attention back to this. I'm hoping to find the cycles next week, but it might have to wait until after FUDcon. Thanks again. I do want to see this done, and I will get on it. Just not right now.
By the way, my interest is in the following work in progress: http://jjmcd.fedorapeople.org/Download/R-2.13-Six_Sigma_with_R_-_A_Tutorial-en-US.pdf
still interested?
Yes, still fixing release notes bugs after digging out from post-FUDcon email avalanche.
Got through? :)
Well, I got some of the fixes made, but there's a new tar with some different files, so I have some work to do, along with tracking down the questionable licensing bits. But the one thing I didn't quite understand: R-qcc.noarch: E: incorrect-fsf-address /usr/share/R/library/qcc/COPYING What's that supposed to be telling me?
(In reply to comment #8) > But the one thing I didn't quite understand: > R-qcc.noarch: E: incorrect-fsf-address /usr/share/R/library/qcc/COPYING > > What's that supposed to be telling me? The FSF address has recently changed and the file mentioned here still contains the old address. This is not a review blocker but you should mention it upstream so that he can update his license file.
Once I actually managed to get back to it, upstream had significantly changed the tar, so a new RPM: http://jjmcd.fedorapeople.org/Download/R-qcc.spec http://jjmcd.fedorapeople.org/Download/R-qcc-2.2-1.fc16.src.rpm Still waiting to hear back from Luca. I suspect the R file is OK, the reference was most likely the text that supported the equations. The R-News is a bit messier, we'll see what he says. R-News has been replaced with the R Journal, which is pretty vague about licensing. It does say "open", but doesn't reference any specifics.
Heard back from Luca, both the R-News article and the demo script are his work and OK to publish.
Two small remarks: - You should use %global instead of %define - The variable packrel is never used
Changes made: http://jjmcd.fedorapeople.org/Download/R-qcc.spec http://jjmcd.fedorapeople.org/Download/R-qcc-2.2-2.fc16.src.rpm Question: I only used packname in those places that apply to pretty much all packages, and explicitly said qcc in places unique to this one. While that makes sense to me, perhaps it isn't the normal practice.
Small changes but if you don't intend to have an EL5 branch there is some cleaning you can do on the spec: - The buildroot http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - The clean section http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean I will try to finish the review tomorrow.
As suggested: http://jjmcd.fedorapeople.org/Download/R-qcc.spec http://jjmcd.fedorapeople.org/Download/R-qcc-2.2-3.fc16.src.rpm
- Spec is good - Sources are clean - Package builds under mock I have nothing to add to the review I did before, so this package is: APPROVED
New Package SCM Request ======================= Package Name: R-qcc Short Description: An R package for quality control charting and statistical process control. Owners: jjmcd Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
Did you build it ?
Now begging for karma https://admin.fedoraproject.org/updates/R-qcc-2.2-3.fc16?_csrf_token=587db8c484d9caafe6e6196746505274d5c554ff
Let's close this bug now. @John, you now you can associate an update with a bug report in bodhi. Bodhi will then close the bug as the package is pushed to stable.