Hide Forgot
Description of problem: This BZ is holder for issue - when I installed rhev-h-6.2-0.5.iso, I used management_server=IP:8443 & management_server_fingerprint=my:fp:... clauses. In this case vdsm-reg fetch wrong ca.crt (it looks it at http://IP:8443/ca.crt). After approval the install failed. Then I changed port => 8080 in vdsm-reg.conf & restart vdsm-reg service, then host was installed successfully. The problem is, that kernel param management_server & management_server_fingerprint stays there. Version-Release number of selected component (if applicable): rhev-h-6.2-0.5.iso How reproducible: 100% Steps to Reproduce: 1. pls read description 2. 3. Actual results: Expected results: Additional info:
The only options that are removed from the boot command line are ones that are explicitly handled in ovirt-early. The management_server option is part of the vdsm plugin and I'm not aware of the management_server_fingerprint option at all. Having these in the boot line does not hurt anything. The tricky thing is that there isn't a way for something like vdsm to tell ovirt what parameters it's expecting. One possible solution: vdsm (or other plugins) write a file in /etc/ovirt-early.d called something like vdsm-ignore-parameters When processing commandline arguments, ovirt-early, reads all files that match the pattern /etc/ovirt-early.d/*-ignore-parameters and ignores all entries in those files. Alan, Does the above make sense for the plugin architecture?
management_server_fingerprint is new vdsm-reg parameter, for checking rhevm cert > Having these in the boot line does not hurt anything. Unless you want to change it: vdsm-config always overwrites values in vdsm-reg.conf by those specified in boot parameters. > Does the above make sense for the plugin architecture? Yeah, we'll need something like you described, but for now it's not a high priority.
Created attachment 522830 [details] Patch Add a directory on ovirt-node called /etc/ovirt-commandline.d where plugins and/or packages can place a file containing a list of command line variables to ignore when setting up the boot params for subsequent boots.
- if ! grep -qw /etc/ovirt-commandline.d/*; then + if ! grep -qw $varname /etc/ovirt-commandline.d/*; then
(In reply to comment #7) > - if ! grep -qw /etc/ovirt-commandline.d/*; then > + if ! grep -qw $varname /etc/ovirt-commandline.d/*; then Oops, dumb mistake, fixed in git but no need to post new patch
Add additional cleanup patch to suppress errors if there are not files in /etc/ovirt-commandline.d diff --git a/scripts/ovirt-early b/scripts/ovirt-early index df3b0cd..28ebd05 100755 --- a/scripts/ovirt-early +++ b/scripts/ovirt-early @@ -653,7 +653,7 @@ start_ovirt_early () { *) # check the params to be ignored before adding to bootparams varname=${i%=*} - if ! grep -qw $varname /etc/ovirt-commandline.d/*; then + if ! grep -qw $varname /etc/ovirt-commandline.d/* 2>/dev/null; then bootparams="$bootparams $i" fi ;;
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1783.html