Spec URL: http://goldmann.fedorapeople.org/package_review/rubygem-aws-sdk/1/rubygem-aws-sdk.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/rubygem-aws-sdk/1/rubygem-aws-sdk-1.0.1-1.fc15.src.rpm Description: Build Ruby applications with the aws-sdk gem that takes the complexity out of coding directly against the web service interfaces. The gem handles common tasks, such as authentication, request retries, XML processing, error handling, and more. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3214121 $ rpmlint ~/rpmbuild/SRPMS/rubygem-aws-sdk-1.0.1-1.fc15.src.rpm rubygem-aws-sdk.src: I: enchant-dictionary-not-found en_US rubygem-aws-sdk.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ./rubygem-aws-sdk.spec ./rubygem-aws-sdk.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
Taking this for a review.
[ OK ] Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname [ OK ] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version [ OK ] Package has proper license (ASL 2.0) [ OK ] The package must have a Requires and a BuildRequires on rubygems [ OK? ] The %prep and %build sections of the specfile should be empty. %build section is missing, but I though it's OK, since it's not required. [ OK ] The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) [ OK ] The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec [ OK] Architecture-specific content must not be installed into %{gemdir} There is no architecture specific content. [ OK] If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch. Marked properly. [ OK ] If the Gem contains binary content (e.g., for a database driver), it must be marked as architecture specific, and all architecture specific content must be moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory] during %install This gem include only SSL certificate, which is not architecture specific. All clear to go so APPROVED. Nice work Marek!
Michal, thank you for this review! New Package SCM Request ======================= Package Name: rubygem-aws-sdk Short Description: AWS SDK for Ruby Owners: goldmann Branches: f14 f15 el5 el6
Git done (by process-git-requests). Michal, in the future, please take ownership of review bugs you're working on. Thanks!
Thank you for review and git!
Why was the cvs flag set again?
TBH, I don't know - maybe it was in browser cache.
rubygem-aws-sdk-1.0.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-aws-sdk-1.0.1-1.fc14
rubygem-aws-sdk-1.0.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-aws-sdk-1.0.1-1.fc15
rubygem-aws-sdk-1.0.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-aws-sdk-1.0.1-1.el6
rubygem-aws-sdk-1.0.2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-aws-sdk-1.0.2-1.fc14
rubygem-aws-sdk-1.0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-aws-sdk-1.0.2-1.el6
rubygem-aws-sdk-1.0.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-aws-sdk-1.0.2-1.fc15
rubygem-aws-sdk-1.0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
rubygem-aws-sdk-1.0.2-1.fc15 has been pushed to the Fedora 15 stable repository.
rubygem-aws-sdk-1.0.2-1.fc14 has been pushed to the Fedora 14 stable repository.
Package Change Request ====================== Package Name: pkgname New Branches: epel7 Owners: blentz goldmann
Invalid package name.
Gah. Sorry. Copy/Paste error. Package Change Request ====================== Package Name: rubygem-aws-sdk New Branches: epel7 Owners: blentz goldmann
blentz is not in the packager group.
Oh, right. FAS username. Duh. Package Change Request ====================== Package Name: rubygem-aws-sdk New Branches: epel7 Owners: wakko666 goldmann
Git done (by process-git-requests).