Spec URL: http://zaneb.fedorapeople.org/libvirt-qmf-0.3.0-1/libvirt-qmf.spec SRPM URL: http://zaneb.fedorapeople.org/libvirt-qmf-0.3.0-1/libvirt-qmf-0.3.0-1.fc15.src.rpm Description: Responsibility for libvirt-qpid has been transferred from libvirt.org to matahariproject.org. We wish to rename the package to libvirt-qmf to better reflect what it does (discussion here: https://fedorahosted.org/pipermail/matahari/2011-July/001370.html). At the same time, libvirt-qmf becomes a matahari agent. Although it provides the same functionality, libvirt-qmf is not intended to be backwards compatible with previous clients of libvirt-qpid (e.g. the schema domain has changed from com.redhat.libvirt to org.libvirt).
Name: ok Summary: ok Source: not ok, please provide full sources url if not generated manually (and then it should be documented) License: ok Obsoletes: should be versioned, see rpmlint output Url: ok Group: ok but not needed anymore in Fedora Requires: not ok, please do not use explicit requires (unless it's runtime dependency not autogenerated by rpm depsolver), ok for scriptlets, see http://fedoraproject.org/wiki/Packaging:Guidelines#Requires BuildRequires: ok but qmf-devel is now qpid-qmf-devel (still provides qmf-devel) Description: ok Build: please use parallel make if possible, see http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - otherwise document it in comment that it's not possible to use it Build: scratch build failed, see http://koji.fedoraproject.org/koji/taskinfo?taskID=3222416 Macros usage consistency: inconsistent %{buildroot} and $RPM_BUILD_ROOT used together, see http://fedoraproject.org/wiki/Packaging:Guidelines#Macros Doc: ok %defattr is not needed explicitely anymore in rpm 4.4+ rpmlint libvirt-qmf-0.3.0-1.fc15.src.rpm libvirt-qmf.src: W: spelling-error Summary(en_US) QPid -> QP id, QP-id, Quid libvirt-qmf.src: W: spelling-error %description -l en_US qpid -> quid, tepid, cupid libvirt-qmf.src:9: W: unversioned-explicit-obsoletes libvirt-qpid libvirt-qmf.src: W: invalid-url Source0: libvirt-qmf-0.3.0.tar.gz 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Updated files: SRPM: http://zaneb.fedorapeople.org/libvirt-qmf-0.3.0-1/libvirt-qmf-0.3.0-1.8d0b22.fc15.src.rpm Spec: http://zaneb.fedorapeople.org/libvirt-qmf-0.3.0-1/libvirt-qmf-0.3.0-1.8d0b22.spec
Thanks Zane, looks ok for me, just one thing - we should probably also Provide libvirt-qpid (in case something depends on it). It's not he must and I'm not sure if anything is using libvirt-qpid at all now. For upgrade paths Obsoletes are ok. http://fedoraproject.org/wiki/Upgrade_paths_—_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F Otherwise APPROVED
Thanks Jaroslav. After some discussion on IRC, we have decided not to Provide libvirt-qpid. Since libvirt-qmf is not backward compatible, now seems like the best time to provide a clean break.
New Package SCM Request ======================= Package Name: libvirt-qmf Short Description: matahari agent for libvirt Owners: zaneb Branches: InitialCC: matahari-maint
Git done (by process-git-requests). Ignored InitialCC, not a valid FAS account.