Hide Forgot
Date of First Response: 2010-03-04 15:09:32 Help Desk Ticket Reference: https://enterprise.redhat.com/issue-tracker/361675 securitylevel_name: Public Please remove all System.out.println statements from the code, for example in org.drools.guvnor.server.CategoryFilter.java: System.out.println("Checking access for : " + makePath(parentPath, child)); and use logging facility instead. If the user decided to change the log4j settings in log4j.xml (web-inf/classes) these messages will still be printed to the console.
Approved for 5.0.2 if done by due date.
Fixes in soa_branches/BRMS-5.0.1
Added to the 5.0.2 release notes as resolved: Some log messages where always being displayed in the console although the log4j configuration specified otherwise. This was because those messages where being displayed using System.out.println statements instead of the log4j logging service. These statements have been replaced with calls to log4j methods and the messages are now displayed according to the the log4j configuration.
Looking at the source checked out from: http://anonsvn.jboss.org/repos/labs/labs/jbossrules/soa_tags/BRMS-5.0.2-CR1/drools-guvnor/src/main/java/org/drools All lines including System.out.println are commented out: $ ls -1 brms guvnor SampleFact.java $ grep -r "System.out.println" * guvnor/server/ServiceImplementation.java: //System.out.println("Cat Rules: " + data.catRules.toString()); guvnor/server/ServiceImplementation.java: //System.out.println("(convertToObjectGraph)list: " + list.toString()); guvnor/server/ServiceImplementation.java: //System.out.println("(convertMapToString)map: " + map.toString()); guvnor/server/ServiceImplementation.java: //System.out.println("(convertMapToString)returnVal: " + returnVal); guvnor/server/files/WebDAVImpl.java: //System.out.println("COMMIT START"); guvnor/server/files/WebDAVImpl.java: //System.out.println("COMMIT END"); guvnor/server/files/WebDAVImpl.java: //System.out.println("creating folder:" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("creating resource:" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("getChildrenNames :" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("getCreationDate :" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("getLastModified :" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("get resource content:" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("get resource length :" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("is folder :" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("is resource :" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("object exist check :" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("remove object:" + uri); guvnor/server/files/WebDAVImpl.java: //System.out.println("ROLLBACK"); guvnor/server/files/WebDAVImpl.java: //System.out.println("set resource content:" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("COMMIT START"); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("COMMIT END"); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("creating folder:" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("creating resource:" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("getChildrenNames :" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("getCreationDate :" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("getLastModified :" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("get resource content:" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("get resource length :" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("is folder :" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("is resource :" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("object exist check :" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("remove object:" + uri); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("ROLLBACK"); guvnor/server/files/.svn/text-base/WebDAVImpl.java.svn-base: //System.out.println("set resource content:" + uri); guvnor/server/contenthandler/ContentHandler.java:// System.out.println(i+" Cat: "+((CategoryItem)(cats.get(i))).getName()); guvnor/server/contenthandler/ContentHandler.java:// System.out.println(i+" Path: "+((CategoryItem)(cats.get(i))).getFullPath()); guvnor/server/contenthandler/ContentHandler.java:// System.out.println("Found rule: " + ruleName + " in categoryRuleHash, Parent Cat: " + parentCat); guvnor/server/contenthandler/ContentHandler.java:// System.out.println("Should have rule in Category to use for my Parent"); guvnor/server/contenthandler/.svn/text-base/ContentHandler.java.svn-base:// System.out.println(i+" Cat: "+((CategoryItem)(cats.get(i))).getName()); guvnor/server/contenthandler/.svn/text-base/ContentHandler.java.svn-base:// System.out.println(i+" Path: "+((CategoryItem)(cats.get(i))).getFullPath()); guvnor/server/contenthandler/.svn/text-base/ContentHandler.java.svn-base:// System.out.println("Found rule: " + ruleName + " in categoryRuleHash, Parent Cat: " + parentCat); guvnor/server/contenthandler/.svn/text-base/ContentHandler.java.svn-base:// System.out.println("Should have rule in Category to use for my Parent"); guvnor/server/.svn/text-base/ServiceImplementation.java.svn-base: //System.out.println("Cat Rules: " + data.catRules.toString()); guvnor/server/.svn/text-base/ServiceImplementation.java.svn-base: //System.out.println("(convertToObjectGraph)list: " + list.toString()); guvnor/server/.svn/text-base/ServiceImplementation.java.svn-base: //System.out.println("(convertMapToString)map: " + map.toString()); guvnor/server/.svn/text-base/ServiceImplementation.java.svn-base: //System.out.println("(convertMapToString)returnVal: " + returnVal);