Affects: Release Notes Help Desk Ticket Reference: https://enterprise.redhat.com/issue-tracker/480553 securitylevel_name: Public Platform JIRA for [JBRULES-2438] loading multiple sheets of single Excel book by one change-set xml
Link: Added: This issue incorporates JBRULES-2438
Link: Added: This issue is incorporated by SOA-1965
Reproduced with a unit test on master too.
Geoffrey De Smet <ge0ffrey.spam> made a comment on jira JBRULES-2438 Actually, it works, as shown here: https://github.com/droolsjbpm/drools/commit/643fba49913b8e01449981f7298ae1c58092b1e0
Geoffrey De Smet <ge0ffrey.spam> made a comment on jira JBRULES-2438 Actually, it works, as shown here: https://github.com/droolsjbpm/drools/commit/643fba49913b8e01449981f7298ae1c58092b1e0 But if multiple sheets use the same RuleTable name it should fail gracefully indeed (changed the issue to this).
It's possible to do it, here's a unit test on 5.3.x (also on 5.4.x and master): https://github.com/droolsjbpm/drools/commit/57df74328e2d7e4b41e80bc43beb6d3264f1374e But if multiple sheets use the same RuleTable name it should fail gracefully. I 'll take a look at that failing gracefully to fix this issue.
Failing gracefully is not possible, because it's specified behavior that newer rules with the same name overwrite older rules with the same name. So, I did the next best thing, document the pitfall in the manual (5.3, 5.4 and master): https://github.com/droolsjbpm/drools/commit/e1165dc908446198c45710ab04c015a6573b3f76
Geoffrey De Smet <ge0ffrey.spam> updated the status of jira JBRULES-2438 to Resolved
Re-opening, after talking with Edson, we need to go for a better solution: <ge0ffrey> Another idea, what if I suffix the sheet name + the row number (instead of just the row number) to TableName? <Edson> Geoffrey, I think that prefixing the rule name with the sheet name as you suggest would be the best solution for this problem.
Geoffrey De Smet <ge0ffrey.spam> updated the status of jira JBRULES-2438 to Reopened
Geoffrey De Smet <ge0ffrey.spam> made a comment on jira JBRULES-2438 Fixed decently on master by adding the sheet name to the rule name generation
Fixed by adding the sheet name into the rule name too.
on 5.3.x (and 5.4 and master): https://github.com/droolsjbpm/drools/commit/ed6b8c549965a86e81727aba35ec680ca89c0143
Verified in BRMS-5.3.1-ER1.
Thanks for providing the release notes text, Geoffrey.