Bug 724448 (BRMS-393) - [GUVNOR-675]Support for BigDecimal in Guided Editor
Summary: [GUVNOR-675]Support for BigDecimal in Guided Editor
Keywords:
Status: MODIFIED
Alias: BRMS-393
Product: JBoss Enterprise BRMS Platform 5
Classification: JBoss
Component: BRM (Guvnor)
Version: 5.1.0.ER1,5.2,BRMS 5.3.0.GA
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
: future
Assignee: manstis
QA Contact: Jiri Locker
URL: http://jira.jboss.org/jira/browse/BRM...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-18 11:01 UTC by Toshiya Kobayashi
Modified: 2020-09-10 21:10 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
JBoss BRMS 5.3 does not support type BigDecimals in the Guide Rule editor.
Clone Of:
: 958409 (view as bug list)
Environment:
Last Closed:
Type: Feature Request


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 797135 0 unspecified ASSIGNED BigDecimal 99.99B in TestScenario results in NumberFormatException 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 797144 0 unspecified MODIFIED BigDecimal 99.99B in Guided Decision Table changes into 0 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 797149 0 unspecified MODIFIED BigDecimal 99.99B have to be copied and pasted into RHS of a Guided Rule 2021-02-22 00:41:40 UTC
Red Hat Issue Tracker BRMS-393 0 Major Closed [GUVNOR-675]Support for BigDecimal in Guided Editor 2016-05-11 05:59:01 UTC

Internal Links: 797135 797144 797149

Description Toshiya Kobayashi 2010-10-18 11:01:38 UTC
Help Desk Ticket Reference: https://c.na7.visual.force.com/apex/Case_View?id=500A0000003hSwE&sfdc.override=1
securitylevel_name: Public

Platform JIRA for [GUVNOR-675]Support for BigDecimal in Guided Editor

Comment 1 Toshiya Kobayashi 2010-10-18 11:02:33 UTC
Link: Added: This issue incorporates GUVNOR-675


Comment 4 Tihomir Surdilovic 2010-10-28 19:21:26 UTC
Toshiya, checked this with trunk and I don't see the problem (unless am not running the right test). Can you show again here how to reproduce this issue in Guvnor by describing your model, rule and a test scenario?



Comment 5 Toshiya Kobayashi 2010-10-29 06:24:54 UTC
Added steps to reproduce, fact model and screen shots to GUVNOR-675
I still see the same issue with trunk.


Comment 6 Michael Anstis 2011-03-09 15:08:34 UTC
Link: Added: This issue incorporates GUVNOR-1240


Comment 7 Rick Wagner 2011-08-25 20:24:39 UTC
GSS prioritizes this 'High'. The customer has a strong need for it, some work has been done on it.

Comment 8 Prakash Aradhya 2011-09-13 13:40:23 UTC
Rick,
I agree we should get this fixed sooner than later.  This has been lingering around for a long time.
Is it OK if we hold off on this for post 5.2 release ?
Unless the customer is asking that they need the fix immediately, I would recommend we defer it to next CP or 5.3.

My only concern is around the amount of time needed to fix this.

Comment 9 manstis 2011-11-10 16:34:58 UTC
We can control how BigDecimals are handled in certain places in Guvnor (i.e. most places I can think of, other than free-form DRL fields). If a field is a BigDecimal we can implicitly construct DRL like this (for example given):

$new.setValue( new BigDecimal( 999.99 ) );

Furthermore, in Guvnor, we no longer escape numerical values in the LHS with quotes, so we'd now do this: $a : FactA( value == 999.99 ). Do you know if this is likely to now cause problems too?

Comment 10 Toshiya Kobayashi 2011-11-11 05:12:48 UTC
> We can control how BigDecimals are handled in certain places in Guvnor (i.e.
> most places I can think of, other than free-form DRL fields). If a field is a
> BigDecimal we can implicitly construct DRL like this (for example given):
> 
> $new.setValue( new BigDecimal( 999.99 ) );

That's nice. But let me correct, just in case... It should be

$new.setValue( new BigDecimal( "999.99" ) );

> Furthermore, in Guvnor, we no longer escape numerical values in the LHS with
> quotes, so we'd now do this: $a : FactA( value == 999.99 ). Do you know if this
> is likely to now cause problems too?

Yes, it will be an issue.
It matches BigDecimal(999.99) but doesn't match BigDecimal("999.99").

Comment 11 Lukáš Petrovický 2011-11-11 11:40:06 UTC
If we're doing BigDecimal, it may be worth making sure that BigInteger works as well.

Comment 13 manstis 2012-01-27 10:06:05 UTC
Should also add support for "BigDecimals" and "BigIntegers" to the Test Scenarios section.

Comment 24 Ryan Zhang 2012-03-21 09:55:41 UTC
Please verify this issue on ER5.

Comment 25 manstis 2012-03-21 12:06:04 UTC
Please see comment #21. It has not been back-ported to 5.3.x. I proposed it is
shifted to the subsequent release.

Comment 29 Ryan Zhang 2012-04-23 07:37:31 UTC
Update status to ON_QA. Please verify them against ER6.

Comment 31 manstis 2012-05-02 12:30:27 UTC
This has been fixed in community release 5.4.

Comment 32 lcarlon 2012-06-08 00:44:54 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
JBoss BRMS 5.3 does not support type BigDecimals in the Guide Rule editor.


Note You need to log in before you can comment on or make changes to this bug.