Bug 725271 - libvirt allows ambiguous XML config wrt <vcpus> and <topology>
Summary: libvirt allows ambiguous XML config wrt <vcpus> and <topology>
Keywords:
Status: CLOSED DUPLICATE of bug 725269
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Eric Blake
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 708892
TreeView+ depends on / blocked
 
Reported: 2011-07-24 22:40 UTC by Cole Robinson
Modified: 2011-11-23 20:25 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-23 20:25:26 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Cole Robinson 2011-07-24 22:40:22 UTC
libvirt shouldn't allow an ambiguous XML configuration regarding CPU
topology. Example, what guest CPU config does the following XML represent?

<domain>
  ...
  <vcpus>3</vcpus>
  <cpu>
    <topology sockets='2' cores='2' threads='2'/>
  </cpu>
  ...
</domain>

It is unclear, and libvirt shouldn't accept that config. What I think libvirt
should do is make sockets= a readonly attribute that just mirrors the old style
<vcpus> value. We just throw out the any value the user passes for sockets= and sync with vcpus.

Then we clarify the docs that for HVM, <vcpus> is not 'logical guest
cpus' or anything like that, it represents a distinct socket to the guest. That
should allow people to edit <vcpus> like normal. And my understanding is that
HVs that do CPU hotplug do it at the socket level anyways, so setvcpus commands
still retain the correct semantics.

Some background: https://bugzilla.redhat.com/show_bug.cgi?id=708892#c2

Comment 3 Dave Allan 2011-11-23 20:25:26 UTC

*** This bug has been marked as a duplicate of bug 725269 ***


Note You need to log in before you can comment on or make changes to this bug.