Bug 725776 - Review Request: perl-IRC-Utils - Common utilities for IRC-related tasks
Summary: Review Request: perl-IRC-Utils - Common utilities for IRC-related tasks
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 726022
TreeView+ depends on / blocked
 
Reported: 2011-07-26 14:18 UTC by Petr Šabata
Modified: 2013-05-07 13:06 UTC (History)
4 users (show)

Fixed In Version: perl-IRC-Utils-0.10-1.fc15
Clone Of:
Environment:
Last Closed: 2011-08-09 01:28:44 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2011-07-26 14:18:24 UTC
Spec URL: http://psabata.fedorapeople.org/pkgs/perl-IRC-Utils/perl-IRC-Utils.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-IRC-Utils/perl-IRC-Utils-0.10-1.fc15.src.rpm
Description:
The functions in this module take care of many of the tasks you are faced
with when working with IRC. Mode lines, ban masks, message encoding and
formatting, etc.

Comment 1 Petr Pisar 2011-07-26 15:15:36 UTC
Source tar ball is original. Ok.
Summary verified from lib/IRC/Utils.pm. Ok.
License verified from LICENSE. Ok.
Description verified from lib/IRC/Utils.pm. Ok.
No XS code, noarch build is Ok.
Build-time dependencies Ok.
All tests pass. Ok.

$ rpmlint perl-IRC-Utils.spec ../SRPMS/perl-IRC-Utils-0.10-1.fc16.src.rpm ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -qlv -p ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 26 16:55 /usr/share/doc/perl-IRC-Utils-0.10
-rw-r--r--    1 root    root                     1641 May 22 18:12 /usr/share/doc/perl-IRC-Utils-0.10/Changes
-rw-r--r--    1 root    root                    18449 May 22 18:12 /usr/share/doc/perl-IRC-Utils-0.10/LICENSE
-rw-r--r--    1 root    root                     1399 May 22 18:12 /usr/share/doc/perl-IRC-Utils-0.10/META.json
-rw-r--r--    1 root    root                    11893 May 22 18:12 /usr/share/doc/perl-IRC-Utils-0.10/README
-rw-r--r--    1 root    root                      582 May 22 18:12 /usr/share/doc/perl-IRC-Utils-0.10/dist.ini
-rw-r--r--    1 root    root                     6234 Jul 26 16:55 /usr/share/man/man3/IRC::Utils.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 26 16:55 /usr/share/perl5/vendor_perl/IRC
-rw-r--r--    1 root    root                    29774 May 22 18:12 /usr/share/perl5/vendor_perl/IRC/Utils.pm
File layout and permissions Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm |sort |uniq -c
      1 perl(base)  
      1 perl(constant)  
      1 perl(Encode)  
      1 perl(Encode::Guess)  
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.14.1)  
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Run-time requires Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm |sort |uniq -c
      1 perl(IRC::Utils) = 0.10
      1 perl-IRC-Utils = 0.10-1.fc16
Run-time provides Ok.

$ resolvedeps dist-f16-build ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm
Binary dependencies resolvable. Ok.

Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3231475). Ok.

Package is in line with Fedora and Perl packaging guidelines.


Resolution: Package APPROVED.

Comment 2 Petr Šabata 2011-07-26 15:22:22 UTC
New Package SCM Request
=======================
Package Name: perl-IRC-Utils
Short Description: Common utilities for IRC-related tasks
Owners: psabata ppisar mmaslano
Branches: f15 f16
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2011-07-26 15:31:41 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2011-07-26 15:51:37 UTC
Thanks for the review and the repository, guys...

Comment 5 Fedora Update System 2011-07-26 15:55:56 UTC
perl-IRC-Utils-0.10-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-IRC-Utils-0.10-1.fc15

Comment 6 Fedora Update System 2011-07-31 03:54:05 UTC
perl-IRC-Utils-0.10-1.fc15 has been pushed to the Fedora 15 testing repository.

Comment 7 Fedora Update System 2011-08-09 01:28:39 UTC
perl-IRC-Utils-0.10-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 8 Andrea Veri 2013-05-07 11:00:41 UTC
Package Change Request
======================
Package Name: perl-IRC-Utils
New Branches: el6
Owners: averi psabata
InitialCC: perl-sig

Comment 9 Gwyn Ciesla 2013-05-07 13:06:21 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.