Spec URL: http://mgieseki.fedorapeople.org/hexglass/hexglass.spec SRPM URL: http://mgieseki.fedorapeople.org/hexglass/hexglass-1.2.1-1.fc15.src.rpm Description: HexGlass is a Tetris-like puzzle game. Ten different types of blocks continuously fall from above and you must arrange them to make horizontal rows of hexagonal bricks. Completing any row causes those hexagonal blocks to disappear and the rest above move downwards. The blocks above gradually fall faster and the game is over when the screen fills up and blocks can no longer fall from the top.
Spec URL: http://mgieseki.fedorapeople.org/hexglass/hexglass.spec SRPM URL: http://mgieseki.fedorapeople.org/hexglass/hexglass-1.2.1-2.fc15.src.rpm A few minor changes: - added Group field - changed GenericName in .desktop file to "Block falling game"
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3237950 $ rpmlint -i -v * hexglass.i686: I: checking hexglass.i686: I: checking-url http://code.google.com/p/hexglass (timeout 10 seconds) hexglass.i686: W: no-manual-page-for-binary hexglass Each executable in standard binary directories should have a man page. hexglass.src: I: checking hexglass.src: I: checking-url http://code.google.com/p/hexglass (timeout 10 seconds) hexglass.src: I: checking-url http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz (timeout 10 seconds) hexglass.src: W: invalid-url Source0: http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. hexglass.x86_64: I: checking hexglass.x86_64: I: checking-url http://code.google.com/p/hexglass (timeout 10 seconds) hexglass.x86_64: W: no-manual-page-for-binary hexglass Each executable in standard binary directories should have a man page. hexglass-debuginfo.i686: I: checking hexglass-debuginfo.i686: I: checking-url http://code.google.com/p/hexglass (timeout 10 seconds) hexglass-debuginfo.x86_64: I: checking hexglass-debuginfo.x86_64: I: checking-url http://code.google.com/p/hexglass (timeout 10 seconds) hexglass.spec: I: checking-url http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz (timeout 10 seconds) hexglass.spec: W: invalid-url Source0: http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. 5 packages and 1 specfiles checked; 0 errors, 4 warnings. Googlecode fails again with the download. No problem, the source package is available, though. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv3+ [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 408148e6b05065d12edd7066b929465b hexglass-1.2.1.tar.gz 408148e6b05065d12edd7066b929465b hexglass-1.2.1.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - See Koji build above. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: The spec file MUST handle locales properly. [+] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. Works fine for me. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. Currently no man page available. ---------------- PACKAGE APPROVED ----------------
BTW, what about to add a German summary and description? Summary(de): Puzzlespiel mit fallenden Blöcken in einem sechseckigen Raster %description -l de HexGlass ist ein Tetris-ähnliches Puzzlespiel. Zehn verschiedene Blocktypen fallen fortwährend nach unten und müssen so angeordnet werden, dass horizontale Zeilen aus sechseckigen Elementen gebildet werden. Durch Vervollständigen einer Zeile verschwinden die Blöcke, wodurch die übrigen nach unten verschoben werden. Mit steigendem Schwierigkeitsgrad fallen die Blöcke schneller. Das Spiel ist vorbei, sobald das Spielfeld vollständig gefüllt ist und keine Blöcke mehr fallen können.
Mario, thank you for the review and the German translations. I'll add them before checking in the package. New Package SCM Request ======================= Package Name: hexglass Short Description: Block falling puzzle game based on a hexagonal grid Owners: mgieseki Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
hexglass-1.2.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/hexglass-1.2.1-3.fc16
hexglass-1.2.1-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/hexglass-1.2.1-3.fc15
hexglass-1.2.1-3.fc16 has been pushed to the Fedora 16 testing repository.
hexglass-1.2.1-3.fc15 has been pushed to the Fedora 15 stable repository.
hexglass-1.2.1-3.fc16 has been pushed to the Fedora 16 stable repository.