726398 – libvirt-0.8.7-18.el6 doesn't correctly log failed hook scripts

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 726398 - libvirt-0.8.7-18.el6 doesn't correctly log failed hook scripts

Summary: libvirt-0.8.7-18.el6 doesn't correctly log failed hook scripts

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libvirt
Sub Component:
Version:	6.1
Hardware:	x86_64
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	rc
Target Release:	---
Assignee:	Osier Yang
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2011-07-28 13:50 UTC by Reto Gantenbein
Modified:	2011-12-06 11:18 UTC (History)
CC List:	7 users (show)
Fixed In Version:	libvirt-0.9.4-1.el6
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2011-12-06 11:18:07 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2011:1513	0	normal	SHIPPED_LIVE	libvirt bug fix and enhancement update	2011-12-06 01:23:30 UTC

Description Reto Gantenbein 2011-07-28 13:50:35 UTC

Description of problem:
libvirtd doesn't correcly log failed hook scripts. According to the libvirt documentation, a log message should appear when the /etc/libvirt/hooks/qemu script returns an exit code != 0. This seems to be a regression in RHEL 6.1, since the behaviour was according the documentation in libvirt-0.8.1 (RHEL 6.0). 

Version-Release number of selected component (if applicable):
libvirt-0.8.7-18.el6


How reproducible:
Always


Steps to Reproduce:
1. Create a qemu hook script that returns with a value != 0
2. Place it in /etc/libvirt/hooks/ and make it executable
3. Restart libvirtd
4. Start a KVM virtual machine
  

Actual results:
The machine startup will fail with an error message:
error : virCommandWait:1226 : internal error Child process exited with status 1.


Expected results:
Error message similar to the one from libvirt 0.8.1:
error : virHookCall:418 : Hook script execution failed: Hook script /etc/libvirt/hooks/qemu qemu failed with error code 256

Comment 2 Osier Yang 2011-07-29 14:43:29 UTC

commit ef765169dd520fb25760387306dea925a28f37cd
Author: Osier Yang <jyang>
Date:   Fri Jul 29 22:40:47 2011 +0800

    utils: More useful error message for hook script failure
    
    Commit 3709a386 ported hooks codes to new command execution API,
    together with the useful error message removed. Though we can't
    get "errbuf" from the new command execution API anymore, still
    we can give a more useful error.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=726398

Patch pushed into upstream, move to POST.

Comment 6 dyuan 2011-08-04 11:08:54 UTC

Reproduced this bug with libvirt-0.9.8-3.el6.

Verified PASS with libvirt-0.9.4-1.el6
pkgs:
qemu-kvm-0.12.1.2-2.176.el6
kernel-2.6.32-176.el6

# cat /etc/libvirt/hooks/qemu 
#! /bin/bash
   if [[ $1 = "dom" ]]; then
       echo "$0" "$@" >> /tmp/qemu.log
       exit 1
   fi

# chmod +x /etc/libvirt/hooks/qemu

# service libvirtd restart
Stopping libvirtd daemon:                                  [  OK  ]
Starting libvirtd daemon:                                  [  OK  ]

# virsh start dom
error: Failed to start domain dom
error: Hook script execution failed: Hook script /etc/libvirt/hooks/qemu qemu failed with error code 256

Comment 7 errata-xmlrpc 2011-12-06 11:18:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html

Note You need to log in before you can comment on or make changes to this bug.