Bug 726416 - Katello-cli is failing on some terminals
Summary: Katello-cli is failing on some terminals
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: katello-agent
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
low vote
Target Milestone: Unspecified
Assignee: Lukas Zapletal
QA Contact: Og Maciel
URL:
Whiteboard:
Depends On:
Blocks: katello-blockers
TreeView+ depends on / blocked
 
Reported: 2011-07-28 14:31 UTC by Lukas Zapletal
Modified: 2019-09-26 15:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-22 17:51:02 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Lukas Zapletal 2011-07-28 14:31:56 UTC 
On some terminals it throws this:

2011-07-28 15:58:19,695 [ERROR][MainThread] error() @ base.py:169 - Traceback (most recent call last):
  File "/data/work/CloudForms/katello/cli/src/katello/client/cli/base.py", line 209, in main
    return command.main(command_args)
  File "/data/work/CloudForms/katello/cli/src/katello/client/core/base.py", line 330, in main
    return self.run()
  File "/data/work/CloudForms/katello/cli/src/katello/client/core/ping.py", line 76, in run
    self.printer.printItems(statusList)
  File "/data/work/CloudForms/katello/cli/src/katello/client/core/utils.py", line 209, in printItems
    self._printHeader(self._heading, widths)
  File "/data/work/CloudForms/katello/cli/src/katello/client/core/utils.py", line 53, in _printHeader
    header_width = self._getTermWidth()
  File "/data/work/CloudForms/katello/cli/src/katello/client/core/utils.py", line 79, in _getTermWidth
    rows, columns = os.popen('stty size', 'r').read().split()
ValueError: need more than 0 values to unpack

Going to fix this.
Comment 1 Lukas Zapletal 2011-07-28 14:33:06 UTC 
d5c70b6 Bug 726416 - Katello-cli is failing on some terminals
Comment 3 Corey Welton 2012-02-14 13:37:44 UTC 
Do we have any details as to what terminals this was failing on and why?
Comment 4 Og Maciel 2012-02-24 20:03:46 UTC 
Lukáš, ping?
Comment 5 Lukas Zapletal 2012-02-27 14:09:23 UTC 
Yes sorry guys. So basically it was failing on an installation without "stty" command.

To simulate that behavior just delete this command for a while or override it with a "test" command symlink or alias.

The change introduced determining the terminal size with a syscall rather than using an external command.
Comment 7 Og Maciel 2012-02-28 20:40:38 UTC 
Validated:
* candlepin-0.5.22-1.el6.noarch
* candlepin-tomcat6-0.5.22-1.el6.noarch
* katello-0.1.300-1.el6.noarch
* katello-all-0.1.300-1.el6.noarch
* katello-certs-tools-1.0.2-2.el6.noarch
* katello-cli-0.1.100-2.el6.noarch
* katello-cli-common-0.1.100-2.el6.noarch
* katello-common-0.1.300-1.el6.noarch
* katello-configure-0.1.100-7.el6.noarch
* katello-glue-candlepin-0.1.300-1.el6.noarch
* katello-glue-foreman-0.1.300-1.el6.noarch
* katello-glue-pulp-0.1.300-1.el6.noarch
* katello-httpd-ssl-key-pair-1.0-1.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-repos-0.1.5-1.el6.noarch
* katello-selinux-0.1.7-1.el6.noarch
* katello-trusted-ssl-cert-1.0-1.noarch
* pulp-1.0.0-2.el6.noarch
* pulp-admin-1.0.0-2.el6.noarch
* pulp-client-lib-1.0.0-2.el6.noarch
* pulp-common-1.0.0-2.el6.noarch
* pulp-selinux-server-1.0.0-2.el6.noarch
Note You need to log in before you can comment on or make changes to this bug.