Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 726437

Summary: Disk write cache flushes are no longer logged in blktrace
Product: Red Hat Enterprise Linux 6 Reporter: Jeff Moyer <jmoyer>
Component: kernelAssignee: Jeff Moyer <jmoyer>
Status: CLOSED ERRATA QA Contact: Gris Ge <fge>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.2CC: bosun, fge, msnitzer, rwheeler, syeghiay
Target Milestone: betaKeywords: Regression
Target Release: 6.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kernel-2.6.32-197.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 13:55:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 736399    
Bug Blocks: 743047    
Attachments:
Description Flags
add BIO_RW_FLUSH to the list of bits to check when flagging barrier requests
none
fix up barrier reporting in blktrace none

Description Jeff Moyer 2011-07-28 15:13:32 UTC
Created attachment 515749 [details]
add BIO_RW_FLUSH to the list of bits to check when flagging barrier requests

Description of problem:
blktrace will no longer display when write cache flushes are sent to the disk, due to the flush/fua conversion.  It was missing a simple conditional in kernel/trace/blktrace.c.  Without this information, it will be difficult to diagnose performance issues in the field.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. run a workload that generates fsyncs
2. record blktrace data
3. observe the absense of WBS requests

Comment 2 RHEL Program Management 2011-07-28 15:30:30 UTC
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 3 Jeff Moyer 2011-07-28 18:03:54 UTC
Created attachment 515778 [details]
fix up barrier reporting in blktrace

This patch reports 'B' in the blktrace output when the flush flag is set in a request or bio.  It also fixes up the translation between blk_add_trace_rq and __blk_add_trace for barrier and discard requests (the latter function checks for BIO_RW_* while the former was setting REQ_*).

Comment 9 Aristeu Rozanski 2011-09-14 21:21:49 UTC
Patch(es) available on kernel-2.6.32-197.el6

Comment 12 Gris Ge 2011-09-16 05:08:35 UTC
kernel 197 with blktrace-1.0.1-6.el6 provide write cache flushes:
========
  8,1    0    20713     2.418776737   737  I FWFS 295626 + 2 [jbd2/sda1-8]
========

I am new to FLUSH/FUA, if this is not what we fix in this bug, correct me.

Thanks.

VERIFY this bug.

Comment 13 errata-xmlrpc 2011-12-06 13:55:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1530.html