Hide Forgot
Created attachment 515751 [details] agent timeout patch The (already pushed) patch from BZ #712938 comment 11 (https://bugzilla.redhat.com/show_bug.cgi?id=712938#c11) caused the following regression: When client runs without the auto-conf or disable-effects options (either from CLI or controller), which is the case when using Spice from Admin Portal, the client will unecessarily wait for 30sec before connecting. The mentioned patch assumed that on_agent_reply() of VD_AGENT_DISPLAY_CONFIG will call send_main_attach_channels() and connect. However, when auto-conf or disable-effects are not used, on_agent_reply() will ignore the reply and not call send_main_attach_channels(). Therefore, send_main_attach_channels() will only be called on agent timeout. The solution is to activate agent timer only if auto-conf or disable-effects. Otherwise, simply call send_main_attach_channels(). Attached a proposed patch by Christophe.
This patch has been sent to the spice-devel mailing list for review.
Verified on spice-client-0.8.2-2/spice-client-msi-3.0-16 (ic136).
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: No documentation needed. The bug was filed during development (as a result of a fix for bug 712938), and never affected customers,
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1518.html