Hide Forgot
Description of problem: version: libvirt-0.9.4-0rc2 How reproducible: Steps to Reproduce: 1. for ((i=0; i < 50; i++)); do virsh managedsave vm1 & done; killall virsh Actual results: libvirtd crashed Expected results: libvirtd is still running Additional info: The reason is that we free virNetServerClient when the refs is not 0. I read the code under the directory src/rpc/, and find we have xxxRef(), but we do not have xxxUnref(). And sometimes we free the data structure if ref is not 0. We add an reference of the data structure, but sometimes we forget to unref it.
Eric, is this being discussed upstream?
Upstream mention: https://www.redhat.com/archives/libvir-list/2011-August/msg00013.html
The reason is that: In the function virNetServerClientClose(), we set client->sock to NULL while we still use it.
Patch proposed: https://www.redhat.com/archives/libvir-list/2011-August/msg00047.html
Reproduced this bug with libvirt-0.9.4-0rc2.el6 and verified pass with libvirt-0.9.4-0rc1.2.el6.
Moved it to VERIFIED according to comment 7.
Tested with libvirt-0.9.4-7.el6, the libvirtd crash with the step in bug description. Re-check with libvirt-0.9.4-0rc1.2.el6, the libvirtd still crash. Please ignore the comment 7 and comment 9, the libvirtd will crash in few seconds but not at once, seems I get the conclusion too hurriedly at that time.
Created attachment 520791 [details] libvirtd.log when the libvirtd crashed
Can you retest with libvirt-0.9.4-12.el6?
Created attachment 524307 [details] error log in libvirtd.log Retest with libvirt-0.9.4-12.el6.x86_64, libvirtd will not crash, but there's some error messages logged in libvirtd.log.
That sounds normal. Some of it seems to be because the max number of clients (20) wasn't raised in libvirtd conf before the test. The cgroup messages are completely unrelated to this bug. The behaviour sounds normal, now, the bug is fixed IMHO, Daniel
Move it to VERIFIED per Comment 13 and Comment 14.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1513.html