Bug 727899 - Review Request: rubygem-selenium-webdriver - The next generation developer focused tool for automated testing of webapps
Summary: Review Request: rubygem-selenium-webdriver - The next generation developer fo...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Huffman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 727879 727887
Blocks: 727909
TreeView+ depends on / blocked
 
Reported: 2011-08-03 15:08 UTC by Chris Lalancette
Modified: 2011-08-04 17:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-04 17:02:05 UTC
bloch: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Chris Lalancette 2011-08-03 15:08:45 UTC
Spec URL: http://people.redhat.com/clalance/rubygem-selenium-webdriver/rubygem-selenium-webdriver.spec
SRPM URL: http://people.redhat.com/clalance/rubygem-selenium-webdriver/rubygem-selenium-webdriver-2.3.2-1.fc14.src.rpm

Description:
WebDriver is a tool for writing automated tests of websites. It aims to mimic
the behavior of a real user, and as such interacts with the HTML of the
application.

Comment 1 Adam Huffman 2011-08-03 22:45:56 UTC
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

[x] : MUST - Package successfully compiles and builds into binary rpms on at least one supported architecture.
[x] : MUST - Fully versioned dependency in subpackages, if present.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package use %makeinstall only when make install DESTDIR=... doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - Sources used to build the package matches the upstream source, as provided in the spec URL.
        /home/adam/tmp/reviewhelper/727909/capybara-1.0.0.gem :
          MD5SUM this package     : 6ee03d9facbb5c65692647f2828ff4ea
          MD5SUM upstream package : 6ee03d9facbb5c65692647f2828ff4ea
        
[x] : MUST - Spec file name must match the spec package %{name}, in the format %{name}.spec.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application.
[-] : MUST - Header files in -devel subpackage, if present.
[-] : MUST - ldconfig called in %post and %postun if required.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - No %config files under /usr.
[-] : MUST - Development .so files in -devel subpackage, if present.
[-] : MUST - Static libraries in -static subpackage, if present.
        
[!] : MUST - Rpmlint output is silent.
- apparently the doc warnings are expected

[x] : MUST - Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
[-] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[-] : MUST - Macros in Summary, %description expandable at SRPM build time.
[-] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[ ] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[x] : MUST - Large documentation files are in a -doc subpackage, if required.
[-] : MUST - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x] : MUST - License field in the package spec file matches the actual license.
[-] : MUST - License file installed when any subpackage combination is installed.
[x] : MUST - Package consistently uses macros. instead of hard-coded directory names.
[x] : MUST - Package meets the Packaging Guidelines.
[x] : MUST - Package does not generates any conflict.
[x] : MUST - Package does not contains kernel modules.
[x] : MUST - Package contains no static executables.
[x] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[x] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[?] : MUST - Package installs properly.
[?] : MUST - Rpath absent or only used for internal libs.
[?] : MUST - Package is not relocatable.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - Spec file is legible and written in American English.
[-] : MUST - Package contains a SysV-style init script if in need of one.
[x] : MUST - File names are valid UTF-8.
[-] : MUST - Useful -debuginfo package or justification otherwise.
[x] : SHOULD - Reviewer should test that the package builds in mock.
[x] : SHOULD - Dist tag is present.
[x] : SHOULD - SourceX / PatchY prefixed with %{name}.
[x] : SHOULD - SourceX is a working URL.
[x] : SHOULD - Spec use %global instead of %define.
[-] : SHOULD - Uses parallel make.
[-] : SHOULD - The placement of pkgconfig(.pc) files are correct.
[?] : SHOULD - If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm -q --requires).
[?] : SHOULD - Package functions as described.
[x] : SHOULD - Latest version is packaged.
[x] : SHOULD - Package does not include license text files separate from upstream.
[?] : SHOULD - Man pages included for all executables.
[-] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise justified.
[-] : SHOULD - Scriptlets must be sane, if used.
[?] : SHOULD - Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
[-] : SHOULD - Package should compile and build into binary rpms on all supported architectures.
[-] : SHOULD - %check is present and all tests pass.
[x] : SHOULD - Packages should try to preserve timestamps of original installed files.

Issues:       
[!] : MUST - Rpmlint output is silent.
- as noted above, this doesn't seem to be regarded as a problem 

- Overall, it looks okay to me but there seem to be some discrepancies with the Ruby-specific guidelines at:

http://fedoraproject.org/wiki/Packaging/Ruby

e.g. it doesn't own %{gemdir}/gems/%{gemname}-%{version}/ and %prep isn't empty

- this may just be a matter of individual style

Comment 2 Adam Huffman 2011-08-03 23:17:39 UTC
Oops - pasted in the wrong section.  The rest is correct:

[x] : MUST - Sources used to build the package matches the upstream source, as provided in the spec URL.
        /home/adam/tmp/reviewhelper/727899/selenium-webdriver-2.3.2.gem :
          MD5SUM this package     : 1177ead16da294a04401aa5923b4cfa0
          MD5SUM upstream package : 1177ead16da294a04401aa5923b4cfa0

Comment 3 Chris Lalancette 2011-08-04 14:01:41 UTC
(In reply to comment #1)
> Issues:       
> [!] : MUST - Rpmlint output is silent.
> - as noted above, this doesn't seem to be regarded as a problem 

Yeah, that happens with all ruby packages, due to the way that rdoc builds documentation files.  This can be ignored.

> 
> - Overall, it looks okay to me but there seem to be some discrepancies with the
> Ruby-specific guidelines at:
> 
> http://fedoraproject.org/wiki/Packaging/Ruby
> 
> e.g. it doesn't own %{gemdir}/gems/%{gemname}-%{version}/ and %prep isn't empty
> 
> - this may just be a matter of individual style

Actually, it does own %{gemdir}/gems/%{gemname}-%{version}; it's just that we use the macro %{geminstdir} to do that.  %prep not being empty is due to the Fedora guidelines being out of date; the unofficial way we have been doing pure ruby rubygems lately is to put everything into %prep and %install.  If you think about it, that makes sense; doing an "rpmbuild -bp <spec>" will then get you a tree that you can look at, even if it is hidden beneath a directory tree.

If the above all makes sense to you, can you set this to fedora-review+ ?  Thanks!

Comment 4 Adam Huffman 2011-08-04 14:56:24 UTC
Thanks for the clarifications.

APPROVED

Comment 5 Chris Lalancette 2011-08-04 15:24:04 UTC
Thanks again!

Comment 6 Chris Lalancette 2011-08-04 15:26:36 UTC
New Package SCM Request
=======================
Package Name: rubygem-selenium-webdriver
Short Description: The next generation developer focused tool for automated testing of webapps
Owners: clalance mmorsi
Branches: f16
InitialCC:

Comment 7 Gwyn Ciesla 2011-08-04 15:42:36 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.