Bug 728286 - Review Request: perl-Module-Extract-VERSION - Extract a module version without running code
Summary: Review Request: perl-Module-Extract-VERSION - Extract a module version withou...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: perl-Test-Version
TreeView+ depends on / blocked
 
Reported: 2011-08-04 15:23 UTC by Paul Howarth
Modified: 2011-09-07 10:11 UTC (History)
2 users (show)

Fixed In Version: perl-Module-Extract-VERSION-1.01-3.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-07 10:11:17 UTC
iarnell: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2011-08-04 15:23:40 UTC
Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Module-Extract-VERSION/branches/fedora/perl-Module-Extract-VERSION.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Module-Extract-VERSION/perl-Module-Extract-VERSION-1.01-2.fc17.src.rpm

Description:
This module lets you pull out of module source code the version number for the
module. It assumes that there is only one $VERSION in the file.

Comment 1 Iain Arnell 2011-08-12 03:59:14 UTC
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=3267269

Comment 2 Iain Arnell 2011-08-12 04:04:32 UTC
You need to filter perl(ExtUtils::MakeMaker::_version) from the automatically detected provides.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3267269

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
752e28122e92edbb0db452f6cce2af62775b589e Module-Extract-VERSION-1.01.tar.gz
752e28122e92edbb0db452f6cce2af62775b589e Module-Extract-VERSION-1.01.tar.gz.srpm

Final provides / requires are sane:

======> perl-Module-Extract-VERSION-1.01-2.fc17.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(ExtUtils::MakeMaker::_version)  
perl(Module::Extract::VERSION) = 1.01
perl-Module-Extract-VERSION = 1.01-2.fc17
====> requires
perl(Carp)  
perl(:MODULE_COMPAT_5.14.1)  
perl(strict)  
perl(subs)  
perl(vars)  
perl(warnings)  
====> obsoletes
====> conflicts

======> perl-Module-Extract-VERSION-1.01-2.fc17.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(ExtUtils::MakeMaker)  
perl(Test::More)  
perl(Test::Pod) >= 1.00
perl(Test::Pod::Coverage) >= 1.00
perl(Test::Prereq)  
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.12 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.12
INFO: Mock Version: 1.1.12
State Changed: lock buildroot
INFO: installing package(s): perl-Module-Extract-VERSION-1.01-2.fc17.noarch.rpm
INFO: Ignored option -c (probably due to merging -yc != -y -c)

================================================================================
 Package
       Arch   Version     Repository                                       Size
================================================================================
Installing:
 perl-Module-Extract-VERSION
       noarch 1.01-2.fc17 /perl-Module-Extract-VERSION-1.01-2.fc17.noarch 6.5 k

Transaction Summary
================================================================================
Install       1 Package(s)

Total size: 6.5 k
Installed size: 6.5 k

Installed:
  perl-Module-Extract-VERSION.noarch 0:1.01-2.fc17                              


State Changed: unlock buildroot
State Changed: end

Comment 3 Paul Howarth 2011-08-12 08:42:23 UTC
(In reply to comment #2)
> You need to filter perl(ExtUtils::MakeMaker::_version) from the automatically
> detected provides.

Whoops. Fixed in -3:

Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Module-Extract-VERSION/branches/fedora/perl-Module-Extract-VERSION.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Module-Extract-VERSION/perl-Module-Extract-VERSION-1.01-3.fc17.src.rpm

Comment 4 Iain Arnell 2011-08-12 08:48:44 UTC
Confirmed. Filtering works with both old and new rpm. The rest of the review stands. APPROVED.

Comment 5 Paul Howarth 2011-08-12 09:04:18 UTC
New Package SCM Request
=======================
Package Name: perl-Module-Extract-VERSION
Short Description: Extract a module version without running code
Owners: pghmcfc
Branches: EL-4 EL-5 EL-6 F-14 F-15 F-16
InitialCC: perl-sig

Thanks for the review Iain.

Comment 6 Gwyn Ciesla 2011-08-12 12:38:15 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2011-08-12 14:26:30 UTC
perl-Module-Extract-VERSION-1.01-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Module-Extract-VERSION-1.01-3.el5

Comment 8 Fedora Update System 2011-08-12 14:26:38 UTC
perl-Module-Extract-VERSION-1.01-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Module-Extract-VERSION-1.01-3.fc15

Comment 9 Fedora Update System 2011-08-12 14:26:46 UTC
perl-Module-Extract-VERSION-1.01-3.el4 has been submitted as an update for Fedora EPEL 4.
https://admin.fedoraproject.org/updates/perl-Module-Extract-VERSION-1.01-3.el4

Comment 10 Fedora Update System 2011-08-12 14:26:54 UTC
perl-Module-Extract-VERSION-1.01-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-Module-Extract-VERSION-1.01-3.fc16

Comment 11 Fedora Update System 2011-08-12 14:27:02 UTC
perl-Module-Extract-VERSION-1.01-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Module-Extract-VERSION-1.01-3.el6

Comment 12 Fedora Update System 2011-08-12 14:27:09 UTC
perl-Module-Extract-VERSION-1.01-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Module-Extract-VERSION-1.01-3.fc14

Comment 13 Fedora Update System 2011-08-23 04:26:02 UTC
perl-Module-Extract-VERSION-1.01-3.fc14 has been pushed to the Fedora 14 stable repository.

Comment 14 Fedora Update System 2011-08-23 04:34:25 UTC
perl-Module-Extract-VERSION-1.01-3.fc15 has been pushed to the Fedora 15 stable repository.

Comment 15 Fedora Update System 2011-08-23 20:21:52 UTC
perl-Module-Extract-VERSION-1.01-3.fc16 has been pushed to the Fedora 16 stable repository.

Comment 16 Fedora Update System 2011-08-30 21:02:39 UTC
perl-Module-Extract-VERSION-1.01-3.el4 has been pushed to the Fedora EPEL 4 stable repository.

Comment 17 Fedora Update System 2011-08-30 21:03:50 UTC
perl-Module-Extract-VERSION-1.01-3.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 18 Fedora Update System 2011-08-30 21:04:10 UTC
perl-Module-Extract-VERSION-1.01-3.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.