Bug 728622 - inconsistent enable config entries
Summary: inconsistent enable config entries
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Candlepin
Classification: Community
Component: candlepin
Version: 0.5
Hardware: All
OS: Solaris
unspecified
medium
Target Milestone: ---
: ---
Assignee: William Poteat
QA Contact: John Sefler
URL:
Whiteboard:
Depends On:
Blocks: rhsm-rhel62
TreeView+ depends on / blocked
 
Reported: 2011-08-05 20:41 UTC by Jesus M. Rodriguez
Modified: 2015-05-14 15:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-30 13:15:24 UTC


Attachments (Terms of Use)

Description Jesus M. Rodriguez 2011-08-05 20:41:18 UTC
Description of problem:
use of enable and enabled. We should be consistent.

candlepin.amqp.enable = false
candlepin.auth.oauth.enabled=true
candlepin.pinsetter.enable=false

Expected results:

Proposed solution: change candlepin.auth.oauth.enabled to be
candlepin.auth.oauth.enable.

Comment 1 Jesus M. Rodriguez 2011-08-05 20:42:56 UTC
These are also enabled and should be enable.

candlepin.auth.trusted.enabled
candlepin.auth.ssl.enabled
candlepin.auth.oauth.enabled
candlepin.auth.basic.enabled

Comment 2 Jesus M. Rodriguez 2011-09-12 15:43:41 UTC
fixed in ead45e96f082d22cb4e3e47ed023f96b3685520e

requires version candlepin-0.4.11 or greater

Comment 4 J.C. Molet 2011-09-27 17:20:20 UTC
in ConfigProperties.java:


[root@mgmt5 config]# cat /root/candlepin/proxy/src/main/java/org/fedoraproject/candlepin/config/ConfigProperties.java | egrep ".enable"

    public static final String TRUSTED_AUTHENTICATION = "candlepin.auth.trusted.enable";
    public static final String SSL_AUTHENTICATION = "candlepin.auth.ssl.enable";
    public static final String OAUTH_AUTHENTICATION = "candlepin.auth.oauth.enable";
    public static final String BASIC_AUTHENTICATION = "candlepin.auth.basic.enable";
    public static final String AMQP_INTEGRATION_ENABLED = "candlepin.amqp.enable";
    public static final String ENABLE_PINSETTER = "candlepin.pinsetter.enable";


===================
there are no instances of "enabled" anywhere in the key/variable mappings for candlepin configs.  They have all been renamed using 'enable'.  All other entries in the config not found in the mapping are ignored (such as the old keys).

marking VERIFIED against:

[root@mgmt5 config]# git branch
  0.2
  0.3
  BETA
* master
  ownergate
[root@mgmt5 config]# git show-ref | grep master
1243076d76a343d157dc49bb0afb2de19ebfc71f refs/heads/master
1243076d76a343d157dc49bb0afb2de19ebfc71f refs/remotes/origin/master


Note You need to log in before you can comment on or make changes to this bug.