Bug 728803 - drupal6-video bundles external source, possibly copylibs
Summary: drupal6-video bundles external source, possibly copylibs
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: drupal6-video
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
 
Reported: 2011-08-07 17:56 UTC by Paul W. Frields
Modified: 2012-08-07 12:40 UTC (History)
5 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2012-08-07 12:40:32 UTC


Attachments (Terms of Use)

Description Paul W. Frields 2011-08-07 17:56:21 UTC
In the video-6.x.4.2 source, the following files look like bundled libraries. They may be copylibs but they should be extracted and packaged separately if not.

plugins/video_s3/includes/S3.php
js/flowplayer-3.2.0.min.js
js/jquery.media.js
js/jquery.metadata.js

This may have been overlooked in the original review.

Comment 1 Gwyn Ciesla 2012-07-24 19:52:49 UTC
Just updated rawhide to 5.2, which removes the first.  I'll keep digging.

Comment 2 Gwyn Ciesla 2012-07-25 15:08:28 UTC
flowplayer is unmodified from the 3.2.0 version, 3.2.12 is current.  I'll see about packaging it.

Comment 3 Gwyn Ciesla 2012-07-25 15:11:20 UTC
jquery.media.js is from:

http://malsup.com/jquery/media/

It's an old version, and they don't do releases.
<headdesk>

Comment 4 Gwyn Ciesla 2012-07-25 15:13:55 UTC
jquery.metadata.js is from:

http://archive.plugins.jquery.com/project/metadata

I *think* it's the latest release.

Comment 5 Gwyn Ciesla 2012-07-30 16:48:11 UTC
I'm not sure we can package flowplayer, the license is GPLv3 with log restrictions.

http://flowplayer.org/download/licenses/license_gpl.html

Flagging FE-LEGAL, we may need to just drop drupal6-video.

Comment 6 Tom "spot" Callaway 2012-08-03 15:03:41 UTC
Red Hat legal advises that the flowplayer license is non-free, because of the unconventional exceptions to the GPLv3.

Comment 7 Paul W. Frields 2012-08-03 16:18:41 UTC
A quick look at the code tells me that stripping out the flowplayer module wouldn't make the module useless.  AFAIK this module is not necessary for any current or planned projects in Fedora, though, so if major reworking is required, I wouldn't oppose dropping it.

Comment 8 Gwyn Ciesla 2012-08-06 17:38:15 UTC
If it were just flowplayer I'd work on it, but since there's also the two jquery bits, and it's a drupal6 module, not drupal7, and we don't *really* need it, I'll drop, unless you want it, Paul.

Comment 9 Tom "spot" Callaway 2012-08-06 17:45:00 UTC
Worth noting that Javascript is exempt from the no-bundling rules.

Comment 10 Gwyn Ciesla 2012-08-06 17:47:23 UTC
Is it?  I thought I remembered that, but couldn't find it specifically.

Comment 12 Gwyn Ciesla 2012-08-06 17:59:29 UTC
Ah, there, thanks.  Needed to zoom out a bit. :)  Of course, I still don't love doing it, so I'll drop unless Paul wants it.

Comment 13 Gwyn Ciesla 2012-08-06 18:00:13 UTC
Maybe.  Thinking about it.

Comment 14 Gwyn Ciesla 2012-08-07 12:40:32 UTC
Looks like flowplayer is non-trivial to pull out, I'll retire this.


Note You need to log in before you can comment on or make changes to this bug.