In the video-6.x.4.2 source, the following files look like bundled libraries. They may be copylibs but they should be extracted and packaged separately if not. plugins/video_s3/includes/S3.php js/flowplayer-3.2.0.min.js js/jquery.media.js js/jquery.metadata.js This may have been overlooked in the original review.
Just updated rawhide to 5.2, which removes the first. I'll keep digging.
flowplayer is unmodified from the 3.2.0 version, 3.2.12 is current. I'll see about packaging it.
jquery.media.js is from: http://malsup.com/jquery/media/ It's an old version, and they don't do releases. <headdesk>
jquery.metadata.js is from: http://archive.plugins.jquery.com/project/metadata I *think* it's the latest release.
I'm not sure we can package flowplayer, the license is GPLv3 with log restrictions. http://flowplayer.org/download/licenses/license_gpl.html Flagging FE-LEGAL, we may need to just drop drupal6-video.
Red Hat legal advises that the flowplayer license is non-free, because of the unconventional exceptions to the GPLv3.
A quick look at the code tells me that stripping out the flowplayer module wouldn't make the module useless. AFAIK this module is not necessary for any current or planned projects in Fedora, though, so if major reworking is required, I wouldn't oppose dropping it.
If it were just flowplayer I'd work on it, but since there's also the two jquery bits, and it's a drupal6 module, not drupal7, and we don't *really* need it, I'll drop, unless you want it, Paul.
Worth noting that Javascript is exempt from the no-bundling rules.
Is it? I thought I remembered that, but couldn't find it specifically.
https://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries
Ah, there, thanks. Needed to zoom out a bit. :) Of course, I still don't love doing it, so I'll drop unless Paul wants it.
Maybe. Thinking about it.
Looks like flowplayer is non-trivial to pull out, I'll retire this.