Bug 729826 - RFE: drop hard-coded default for os_ver:
RFE: drop hard-coded default for os_ver:
Status: CLOSED CURRENTRELEASE
Product: Publican
Classification: Community
Component: publican (Show other bugs)
2.6
Unspecified Unspecified
unspecified Severity unspecified
: 2.7
: ---
Assigned To: Jeff Fearn
Ruediger Landmann
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-10 20:04 EDT by Ruediger Landmann
Modified: 2011-09-05 23:56 EDT (History)
2 users (show)

See Also:
Fixed In Version: 2.7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2011-09-05 23:56:44 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ruediger Landmann 2011-08-10 20:04:48 EDT
Description of problem:
The os_ver parameter provides the value for the "dist" value used to build a package. Presently, it defaults to ".el5", but can be overridden in the config file. This is counter-intuitive behaviour for anyone building RPMs on any OS other than Red Hat Enterprise Linux 5 or its clones. For example, it's not how rpmbuild behaves. 

I think it's still useful to provide os_ver as a customizable value, for times when someone might want to build a package for an OS other than the one they're using, but the value should default to their own OS, the way that rpmbuild does.

Version-Release number of selected component (if applicable):
2.6-3

How reproducible:
100%

Steps to Reproduce:
1. Package a book on an OS other than Red Hat Enterprise Linux 5 or its clones; ensure that os_ver is not set in the config file.
  
Actual results:
Package NVR includes .el5

Expected results:
If no os_ver is set, package NVR should include the dist value for the OS on which the package was built.


Additional info:
Comment 1 Jeff Fearn 2011-08-10 23:45:30 EDT
Changed code so that if os_ver is not set then dist doesn't get supplied to rpmbuild, removed default os_ver value.

This means that without os_ver rpmbuild will use the OS the build is being run on.

Committed revision 1860.
Comment 2 Jeff Fearn 2011-09-05 23:56:44 EDT
Publican 2.7 has been release and includes a fix for this issue.

Note You need to log in before you can comment on or make changes to this bug.