Bug 730047 (perl-Hash-FieldHash) - Review Request: perl-Hash-FieldHash - Lightweight field hash implementation
Summary: Review Request: perl-Hash-FieldHash - Lightweight field hash implementation
Alias: perl-Hash-FieldHash
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Hash-Fiel...
Depends On:
TreeView+ depends on / blocked
Reported: 2011-08-11 15:54 UTC by Iain Arnell
Modified: 2011-09-07 03:25 UTC (History)
3 users (show)

Fixed In Version: perl-Hash-FieldHash-0.10-2.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-09-02 05:29:03 UTC
Type: ---
emmanuel: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Iain Arnell 2011-08-11 15:54:16 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Hash-FieldHash.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Hash-FieldHash-0.10-1.fc17.src.rpm

Hash::FieldHash provides the field hash mechanism which supports the inside-
out technique.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3266244


Comment 1 Emmanuel Seyman 2011-08-20 08:31:39 UTC

Comment 2 Emmanuel Seyman 2011-08-20 09:22:24 UTC
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated


 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3288737

 [x] Rpmlint output:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
None specified, default used

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
bb8cb7ac175b7021f8ea1afe4f502ef5  Hash-FieldHash-0.10.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] Package does not own files or directories owned by other packages.


 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [?] Reviewer should test that the package builds in mock.
Mock fails on me with an I/O error. I doubt there's any problem though.

 [x] Package should compile and build into binary rpms on all supported
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3288737
 [ ] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=20, Tests=234,  1 wallclock secs ( 0.08 usr  0.02 sys +  0.56 cusr  0.08 csys =  0.74 CPU)
Result: PASS

I'm unsure as to why your Requires and BuildRequires are versionned.
Enforcing "perl >= 1:5.8.5" is next to useless and I don't think we've ever had a version of "perl(Test::LeakTrace)" lower than 0.10, let alone 0.07 .

Probably best to remove those versions which aren't truly needed although I won't block on this.


Comment 3 Iain Arnell 2011-08-21 07:12:18 UTC
New Package SCM Request
Package Name: perl-Hash-FieldHash
Short Description: Lightweight field hash implementation
Owners: iarnell
Branches: f14 f15 f16
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2011-08-21 13:18:38 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2011-08-23 06:58:19 UTC
perl-Hash-FieldHash-0.10-2.fc15 has been submitted as an update for Fedora 15.

Comment 6 Fedora Update System 2011-08-23 06:58:27 UTC
perl-Hash-FieldHash-0.10-2.fc14 has been submitted as an update for Fedora 14.

Comment 7 Fedora Update System 2011-08-23 06:58:35 UTC
perl-Hash-FieldHash-0.10-2.fc16 has been submitted as an update for Fedora 16.

Comment 8 Fedora Update System 2011-08-23 13:32:43 UTC
perl-Hash-FieldHash-0.10-2.fc16 has been pushed to the Fedora 16 testing repository.

Comment 9 Fedora Update System 2011-09-02 05:28:55 UTC
perl-Hash-FieldHash-0.10-2.fc14 has been pushed to the Fedora 14 stable repository.

Comment 10 Fedora Update System 2011-09-02 05:33:00 UTC
perl-Hash-FieldHash-0.10-2.fc15 has been pushed to the Fedora 15 stable repository.

Comment 11 Fedora Update System 2011-09-07 03:25:16 UTC
perl-Hash-FieldHash-0.10-2.fc16 has been pushed to the Fedora 16 stable repository.

Note You need to log in before you can comment on or make changes to this bug.