Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-list.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-list-0.1.0-1.fc14.src.rpm Description: Telepathy contact list application
Name: ok License: ok Source: wrong URL, should be http://download.kde.org/unstable/telepathy-kde/%{version}/src/telepathy-kde-contact-list_%{version}.tar.bz2 instead of http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/telepathy-kde-contact-list_%{version}.tar.bz2 BRs/Reqs: ok Macros used consistently: ok ldconfig: not needed Desktop file validations: ok Docs: ok Devel: NA Files: file /usr/share/applications/kde4/telepathy-kde-contactlist.desktop shouldn't have executable permission Build: ok rpmlint: telepathy-kde-contact-list.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4) telepathy-kde-contact-list.x86_64: E: script-without-shebang /usr/share/applications/kde4/telepathy-kde-contactlist.desktop telepathy-kde-contact-list.x86_64: W: no-manual-page-for-binary telepathy-kde-contactlist
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-list.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-list-0.1.0-2.fc15.src.rpm %changelog * Wed Sep 14 2011 Rex Dieter <rdieter> 0.1.0-2 - fix Source0 URL - fix mixed tabs/spaces The executable .desktop file thing is mostly harmless. in fact, kde is shipping most .desktop files as executable these days (an added security measure).
Thanks for fixing the issues, setting fedora-review+.
New Package SCM Request ======================= Package Name: telepathy-kde-contact-list Short Description: Telepathy contact list application Owners: jreznik rdieter Branches: f15 f16
Git done (by process-git-requests).
imported