Bug 730326 - Review Request: telepathy-kde-contact-list - Telepathy contact list application
Summary: Review Request: telepathy-kde-contact-list - Telepathy contact list application
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: telepathy-qt4
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-08-12 13:53 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-18 17:40:31 UTC
rnovacek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Radek Novacek 2011-09-12 13:51:57 UTC
Name: ok
License: ok
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/telepathy-kde-contact-list_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/telepathy-kde-contact-list_%{version}.tar.bz2
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: not needed
Desktop file validations: ok
Docs: ok
Devel: NA
Files: file /usr/share/applications/kde4/telepathy-kde-contactlist.desktop shouldn't have executable permission
Build: ok
rpmlint:
telepathy-kde-contact-list.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)
telepathy-kde-contact-list.x86_64: E: script-without-shebang /usr/share/applications/kde4/telepathy-kde-contactlist.desktop
telepathy-kde-contact-list.x86_64: W: no-manual-page-for-binary telepathy-kde-contactlist

Comment 2 Rex Dieter 2011-09-15 13:35:25 UTC
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-list.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-list-0.1.0-2.fc15.src.rpm

%changelog
* Wed Sep 14 2011 Rex Dieter <rdieter@fedoraproject.org> 0.1.0-2
- fix Source0 URL
- fix mixed tabs/spaces

The executable .desktop file thing is mostly harmless.  in fact, kde is shipping most .desktop files as executable these days (an added security measure).

Comment 3 Radek Novacek 2011-09-16 06:25:47 UTC
Thanks for fixing the issues, setting fedora-review+.

Comment 4 Rex Dieter 2011-09-16 14:36:25 UTC
New Package SCM Request
=======================
Package Name: telepathy-kde-contact-list
Short Description: Telepathy contact list application
Owners: jreznik rdieter
Branches: f15 f16

Comment 5 Gwyn Ciesla 2011-09-17 01:59:14 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2011-09-18 17:40:31 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.