Bug 730332 - Review Request: telepathy-kde-text-ui - Telepathy text chat handler
Summary: Review Request: telepathy-kde-text-ui - Telepathy text chat handler
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: telepathy-qt4
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-08-12 14:00 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-18 17:43:34 UTC
rnovacek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Radek Novacek 2011-09-13 08:08:14 UTC
Name: ok
License: ok
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/telepathy-kde-text-ui_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/telepathy-kde-text-ui_%{version}.tar.bz2
BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: missing (should be present, installs file to /usr/lib(64)/)
Desktop file validations: not needed
Docs: ok
Devel: ok
Files: ok
Build: ok
rpmlint:
telepathy-kde-text-ui.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)
telepathy-kde-text-ui.x86_64: E: invalid-soname /usr/lib64/libktelepathy_chat_lib.so libktelepathy_chat_lib.so
telepathy-kde-text-ui.x86_64: E: zero-length /usr/share/kde4/apps/ktelepathy/styles/simkete/Contents/Resources/Header.html
telepathy-kde-text-ui.x86_64: E: zero-length /usr/share/kde4/apps/ktelepathy/styles/simkete/Contents/Resources/Footer.html
telepathy-kde-text-ui.x86_64: W: no-manual-page-for-binary telepathy-kde-text-ui
telepathy-kde-text-ui.x86_64: W: no-manual-page-for-binary adiumxtra-protocol-handler
telepathy-kde-text-ui-devel.noarch: W: no-documentation

Comment 2 Rex Dieter 2011-09-15 14:04:05 UTC
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-text-ui.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-text-ui-0.1.0-2.fc15.src.rpm

%changelog
* Thu Sep 15 2011 Rex Dieter <rdieter@fedoraproject.org> 0.1.0-2
- fix Source0 URL
- fix tabs/spaces

Comment 3 Radek Novacek 2011-09-16 06:23:34 UTC
Thanks for fixing the issues, setting fedora-review+.

Comment 4 Rex Dieter 2011-09-16 14:38:08 UTC
New Package SCM Request
=======================
Package Name: telepathy-kde-text-ui
Short Description: Telepathy text chat handler
Owners: jreznik rdieter
Branches: f15 f16

Comment 5 Gwyn Ciesla 2011-09-17 02:02:19 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2011-09-18 17:43:34 UTC
imported.


Note You need to log in before you can comment on or make changes to this bug.