Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 732015

Summary:	Insufficient memory for the terminating null of the string
Product:	Red Hat Enterprise Linux 6	Reporter:	Michal Luscon <mluscon>
Component:	libvirt-snmp	Assignee:	Laine Stump <laine>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.2	CC:	ajia, dallan, dyuan, kdudka, laine, mzhan, rwu, whuang, xhu
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-snmp-0.0.2-3.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 14:49:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	748554

Description Michal Luscon 2011-08-19 13:18:35 UTC

Description of problem:

/src/libvirtGuestTable_data_get.c:204 - Strlen returns length of string, not including the terminating '\0' character.

/src/libvirtGuestTable_data_get.c:218 - Destination string is filled without terminating character.

Version-Release number of selected component (if applicable):
0.0.2-1

Additional info:
This issue was found during the analysis of Coverity scan report.

Comment 4 Laine Stump 2011-10-18 18:16:47 UTC

Fixes for all the problems uncovered by coverity have been pushed upstream:

commit 51e5c3014d7d162d7d8a2aaccb42b6a0092b825d
Author: Laine Stump <laine>
Date:   Tue Oct 18 13:07:50 2011 -0400

    fix startup logic for selecting stderr vs syslog
    
    This bug was uncovered by coverity during the run that resulted in the
    filing of the following bug:
    
       https://bugzilla.redhat.com/show_bug.cgi?id=732015
    
    use_syslog was initialized to 0, and then if the "Use stderr" option
    was selected, it was set to ... "0"!
    
    Rather than simply initializing to 1, I decided to reduce confusion by
    renaming the variable to "use_stderr", leave it initialized to 0, then
    set to 1 when the user asks for stderr.

commit e5b3fd6b6ef3cd8fda00f74291e6fb2174cc806b
Author: Laine Stump <laine>
Date:   Tue Oct 18 12:47:45 2011 -0400

    eliminate bogus check for "NULL" array
    
    This is another bug found by coverity in:
    
       https://bugzilla.redhat.com/show_bug.cgi?id=732015
    
    Apparently libvirtGuestUUID was originally a pointer, and the code was
    making sure that it had memory allocated, but now it is an array that
    is contained in the structure, so checking for NULL makes no sense.

commit 17e238092ccaa3d6386ab668b651b3031f009e60
Author: Laine Stump <laine>
Date:   Tue Oct 18 12:40:41 2011 -0400

    allocate enough space for trailing NULL in string
    
    This bug was found by coverity. See:
    
      https://bugzilla.redhat.com/show_bug.cgi?id=732015

Comment 8 Alex Jia 2011-10-19 11:15:16 UTC

I can reproduce this issue and the latest Coverity result is fine for libvirt-snmp-0.0.2-2.el6, I haven't seen previous errors again and everything is okay, please see http://releng-test1.englab.brq.redhat.com/covscan/task/177/, so move the bug to VERIFIED status.

Alex

Comment 12 Alex Jia 2011-10-19 16:06:40 UTC

Move the bug to VERIFIED status based on latest Coverity result:
http://releng-test1.englab.brq.redhat.com/covscan/task/179/

Comment 13 errata-xmlrpc 2011-12-06 14:49:09 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2011-1609.html