Description of problem: FileSystemConnectorCreateWorkspacesTest.shouldBeAbleToCreateThenDestroyThenRecreateWorkspace is failing on Windows machines with following exception: org.modeshape.graph.request.InvalidWorkspaceException: Could not create the directory "w:\workspace\brms-modeshape-single\modeshape\extensions\modeshape-connector-filesystem\something bogus2011-08-23T09:29:12.920-04:00" for the file system source "Test Repository" at org.modeshape.connector.filesystem.FileSystemRepository.createDirectory(FileSystemRepository.java:112) at org.modeshape.connector.filesystem.FileSystemRepository.getWorkspaceDirectory(FileSystemRepository.java:126) at org.modeshape.connector.filesystem.FileSystemWorkspace.<init>(FileSystemWorkspace.java:100) at org.modeshape.connector.filesystem.FileSystemRepository$FileSystemTransaction.getWorkspace(FileSystemRepository.java:192) at org.modeshape.connector.filesystem.FileSystemRepository$FileSystemTransaction.getWorkspace(FileSystemRepository.java:165) at org.modeshape.graph.connector.base.Repository.createWorkspace(Repository.java:236) at org.modeshape.graph.connector.base.Processor.process(Processor.java:452) at org.modeshape.graph.request.processor.RequestProcessor.process(RequestProcessor.java:253) at org.modeshape.graph.connector.base.Connection.execute(Connection.java:115) at org.modeshape.graph.Graph.execute(Graph.java:288) at org.modeshape.graph.Graph$5.process(Graph.java:231) at org.modeshape.graph.request.RequestBuilder.createWorkspace(RequestBuilder.java:89) at org.modeshape.graph.Graph$6.named(Graph.java:401) at org.modeshape.graph.connector.test.WorkspaceConnectorTest.shouldBeAbleToCreateThenDestroyThenRecreateWorkspace(WorkspaceConnectorTest.java:300) I think that the problem is caused by directory name, because colons are not allowed in directory name on Windows. How reproducible: Run unit tests on Windows machine.
Commit ID: fdc9b1d8101c31129d11 to ModeShape 2.5.x branch.
Verified fixed in 5.2.0 ER3.