Spec URL: http://hushan.fedorapeople.org/pkgs/filebench.spec SRPM URL: http://hushan.fedorapeople.org/pkgs/filebench-1.4.9-1.el6.src.rpm Description: Filebench is a file system and storage benchmark that allows to generate a high variety of workloads. It employs extensive Workload Model Language (WML) for detailed workload specification.
test build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3300058
Don't ship INSTALL. Defattr is no longer necessary, if you don't aim for EPEL4 or older. Use the name macro in the files section. You can shorten the files section to: %files %doc AUTHORS ChangeLog COPYING LICENSE NEWS README TODO %{_bindir}/%{name} %{_datadir}/%{name} Rpmlint: filebench.x86_64: W: file-not-utf8 /usr/share/doc/filebench-1.4.9/LICENSE filebench.x86_64: W: no-manual-page-for-binary filebench At least Sun had some sort of manpage, as far as I can see. Please change the encoding of the licensefile to UTF-8 in the first place.
remove defattr, and INSTALL in doc files, and convert LICENSE to utf-8 encoding: Spec URL: http://hushan.fedorapeople.org/pkgs/filebench.spec SRPM URL: http://hushan.fedorapeople.org/pkgs/filebench-1.4.9-2.el6.src.rpm
test build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3314413
I meant to convert the license file outside of the spec file -- before even packaging it. Do you plan to maintain this package in EPEL5 too? Did you find out about a man page? Maybe you could try to include some sort of excerpt of the documentation in the wiki? It is somewhat different from the README file.
(In reply to comment #5) > I meant to convert the license file outside of the spec file -- before even > packaging it. ah, right, will do it, :) > > Do you plan to maintain this package in EPEL5 too? yes, I will package for epel6 and 5 as well. > > Did you find out about a man page? Maybe you could try to include some sort of > excerpt of the documentation in the wiki? It is somewhat different from the > README file. I dont find direct man pages, but I can make one from wiki documentation, will update the package, thanks.
I made the manpage based the wiki documentation, http://hushan.fedorapeople.org/pkgs/filebench.1 can you please review if it is ok?
There is a spelling error in the manpage: "apporpriate" instead of "appropriate" I don't know whether "tunables" is a proper word. I think, the manpage you created helps a lot.
updated: 1. use utf-8 encoded license file 2. add man page for /usr/bin/filebench Spec URL: http://hushan.fedorapeople.org/pkgs/filebench.spec SRPM URL: http://hushan.fedorapeople.org/pkgs/filebench-1.4.9-3.el6.src.rpm test build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3322151
The only thing to change is the macro use of %{buildroot} -- see below. Please try to contact upstream on shipping a license file. Review: [+] Good [-] Needs work [0] Does not apply MUST: ===== [+] rpmlint: [makerpm@fedora15 ~]$ rpmlint rpmbuild/SRPMS/filebench-1.4.9-3.el6.src.rpm rpmbuild/RPMS/x86_64/filebench-*1.4.9-3.fc15.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. [+] Naming according to the Package Naming Guidelines [+] Spec file matches base package name [+] Packaging guidelines met [+] License approved for Fedora [+] License field in spec matches code [+] License file included, if source package includes it [+] Spec in American English [+] Spec is legible [+] Sources match upstream md5sum: a78d9c6a3f9933d5b282b34e8172af0e [+] Compiles and builds into binary RPMs on at least one primary architecture: x86_64, i386 [0] ExcludeArch is specified and commented [0] Locales are handled correctly [+] All build dependencies listed [0] Calls ldconfig for its shared libraries [+] No bundled system libraries [0] Stated as relocatable package [+] Owns all its directories or requires package that does [+] No file listing duplicates [+] File permissions correct [-] Consistent use of macros --> Use either %{buildroot} or $RPM_BUILD_ROOT [+] Code or permissible content [0] Large documentation in -doc subpackage [+] No runtime dependency of files listed as %doc [0] Header files in -devel subpackage [0] Static files in -static subpackage [0] Library files without suffix in -devel subpackage [0] Devel-package requires base package [0] No .la libtool archives [+] GUI application includes properly installed %{name}.desktop file [+] No files or directories owned, that other packages own [+] Filenames in packages are UTF-8 SHOULD: ======= [-] Query upstream if no license text is included [+] Package builds in mock: fedora-rawhide-x86_64, epel-6-x86_64, epel-5-i386 [+] Package works as described [0] Scriptlets are sane, if used [0] Subpackages other than -devel should require base package (versioned) [0] pkgconfig files in -devel subpackage [0] Dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself [+] Contain man pages, where they make sense
Updated: 1. use $RPM_BUILD_ROOT for consistency Spec URL: http://hushan.fedorapeople.org/pkgs/filebench.spec SRPM URL: http://hushan.fedorapeople.org/pkgs/filebench-1.4.9-4.el6.src.rpm I have also sent a mail to the upstream mailinglist about the shipping LICENSE in the released tarball, I guess they will included it in the next release.
"1. use $RPM_BUILD_ROOT for consistency" No, you don't! ;) mkdir -p %{buildroot}%{_mandir}/man1
ah, sorry, missed that one. fixed: http://hushan.fedorapeople.org/pkgs/filebench.spec
===APPROVED===
thanks Volker for review!
New Package SCM Request ======================= Package Name: filebench Short Description: A model based file system workload generator Owners: hushan Branches: f16 f15 f14 el6 el5 InitialCC:
Git done (by process-git-requests).
filebench-1.4.9-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/filebench-1.4.9-5.fc16
filebench-1.4.9-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/filebench-1.4.9-5.fc15
filebench-1.4.9-5.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/filebench-1.4.9-5.fc14
filebench-1.4.9-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/filebench-1.4.9-5.el6
filebench-1.4.9-5.el6 has been pushed to the Fedora EPEL 6 testing repository.
filebench-1.4.9-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/filebench-1.4.9-6.el5
filebench-1.4.9-5.fc14 has been pushed to the Fedora 14 stable repository.
filebench-1.4.9-5.fc15 has been pushed to the Fedora 15 stable repository.
filebench-1.4.9-5.el6 has been pushed to the Fedora EPEL 6 stable repository.
filebench-1.4.9-6.el5 has been pushed to the Fedora EPEL 5 stable repository.
filebench-1.4.9-5.fc16 has been pushed to the Fedora 16 stable repository.