Bug 733572 - Review Request: gnome-schedule - A graphical interface to crontab and at
Summary: Review Request: gnome-schedule - A graphical interface to crontab and at
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-08-26 04:30 UTC by Rahul Sundaram
Modified: 2011-08-26 15:53 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-26 15:53:28 UTC
kalevlember: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rahul Sundaram 2011-08-26 04:30:41 UTC
Spec URL: http://sundaram.fedorapeople.org/packages/gnome-schedule.spec
SRPM URL: http://sundaram.fedorapeople.org/packages/gnome-schedule-2.1.4-1.fc15.src.rpm
Description: 
Gnome schedule is a graphical user interface that leverages the power of cron
and at to manage your crontab file and provide an easy way to schedule tasks 
on your computer. It supports recurrent (periodical) tasks and tasks that happen 
only once in the future.

Note: This package was retired in Fedora due to FTBFS and dependency on applet no longer supported in GNOME Shell. A new upstream release has disabled applet by default and hence I am reviving it back

Comment 1 Rahul Sundaram 2011-08-26 04:38:45 UTC
Scratch build

http://koji.fedoraproject.org/koji/watchlogs?taskID=3302296

Comment 2 Kalev Lember 2011-08-26 06:45:19 UTC
Fedora review gnome-schedule-2.1.4-1.fc15.src.rpm  2011-08-26

+ OK
! needs attention

$ rpmlint /home/kalev/rpmbuild/SRPMS/gnome-schedule-2.1.4-1.fc16.src.rpm \
          gnome-schedule
gnome-schedule.src: W: spelling-error Summary(en_US) crontab -> contactable
gnome-schedule.src: W: spelling-error %description -l en_US cron -> corn, con, crone
gnome-schedule.src: W: spelling-error %description -l en_US crontab -> contactable
gnome-schedule.noarch: W: spelling-error Summary(en_US) crontab -> contactable
gnome-schedule.noarch: W: spelling-error %description -l en_US cron -> corn, con, crone
gnome-schedule.noarch: W: spelling-error %description -l en_US crontab -> contactable
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/addWindow.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/mainWindow.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/at.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/lang.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/crontabEditorHelper.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/db.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/template_manager.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/gnome-schedule-import.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/gnome-schedule-export.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/template.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/data.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/setuserWindow.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/doc/gnome-schedule-2.1.4/COPYING
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/crontab.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/crontabEditor.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/atEditor.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/template_chooser.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/xwrapper.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/gnome-schedule.py
gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/config.py
gnome-schedule.noarch: W: no-manual-page-for-binary gnome-schedule-export
gnome-schedule.noarch: W: no-manual-page-for-binary gnome-schedule
gnome-schedule.noarch: W: no-manual-page-for-binary gnome-schedule-import
2 packages and 0 specfiles checked; 20 errors, 9 warnings.

+ rpmlint warnings are harmless
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
! The source files in the tarball appear to have GPLv2+ license headers
  (with the 'or any later version' clause) but the license tag in the
  spec file has GPLv2 (the v2-only version).
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  af7d4912402be83c969d8d072d101ccc  gnome-schedule-2.1.4.tar.gz
  af7d4912402be83c969d8d072d101ccc  Download/gnome-schedule-2.1.4.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ No duplicated files in %files section
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
+ Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8


There package needs to depend on some additional python modules. I get the following when trying to run it on F16:

> $ gnome-schedule
> Traceback (most recent call last):
>   File "/usr/share/gnome-schedule/gnome-schedule.py", line 27, in <module>
>     import mainWindow
>   File "/usr/share/gnome-schedule/mainWindow.py", line 26, in <module>
>     import gnome
> ImportError: No module named gnome

Installing gnome-python2-gnome and gnome-python2-bonobo was enough to make it work.


Please review the licensing (GPLv2 vs GPLv2+) and fix the missing deps on python modules and the package should be good to go in.

Comment 3 Rahul Sundaram 2011-08-26 06:55:07 UTC
FYI,  I already mailed upstream asking them to update the address in the license headers but that isn't a blocker.  Fixed the license tag and added the missing requires.  Thanks. 

http://sundaram.fedorapeople.org/packages/gnome-schedule.spec
http://sundaram.fedorapeople.org/packages/gnome-schedule-2.1.4-1.fc15.src.rpm

Comment 4 Rahul Sundaram 2011-08-26 06:55:43 UTC
Second link should be

http://sundaram.fedorapeople.org/packages/gnome-schedule-2.1.4-2.fc15.src.rpm

Comment 5 Kalev Lember 2011-08-26 07:06:26 UTC
(In reply to comment #3)
> FYI,  I already mailed upstream asking them to update the address in the
> license headers but that isn't a blocker.

Agreed; that's why I didn't mention it in the review in the first place. In my opinion rpmlint should make it a warning instead of an error.


> Fixed the license tag and added the missing requires.  Thanks. 

Excellent, looks good now.

APPROVED

Comment 6 Rahul Sundaram 2011-08-26 07:14:19 UTC
Yep.  You could file that issue with rpmlint.  Thanks for the quick review

New Package SCM Request
=======================
Package Name: gnome-schedule
Short Description: 
Owners: sundaram
Branches: f15 f16 
InitialCC:

Comment 7 Kalev Lember 2011-08-26 07:39:24 UTC
(In reply to comment #6)
> Yep.  You could file that issue with rpmlint.

There already is one: https://bugzilla.redhat.com/show_bug.cgi?id=700095

Comment 8 Gwyn Ciesla 2011-08-26 09:52:02 UTC
No description in SCM request.

Comment 9 Rahul Sundaram 2011-08-26 11:18:15 UTC
Yep.  You could file that issue with rpmlint.  Thanks for the quick review

New Package SCM Request
=======================
Package Name: gnome-schedule
Short Description: A graphical interface to crontab and at
Owners: sundaram
Branches: f15 f16 
InitialCC:

Comment 10 Gwyn Ciesla 2011-08-26 13:05:20 UTC
Unretired rawhide, please take ownership of rawhide and f15, then submit a
SCM request for a new f16 branch.  Thanks!

Comment 11 Rahul Sundaram 2011-08-26 15:18:01 UTC
Package Change Request
======================
Package Name: gnome-schedule
New Branches: f16
Owners: sundaram

Comment 12 Gwyn Ciesla 2011-08-26 15:36:18 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.