scilab (under review, bug #472639 ), seems to require a flexdock 0.5.2 , so an update would be nice. :)
This update is straightforward. There are no ABI/API changes. Mainly a bug fixes release.
Created attachment 520222 [details]
I already sent a private mail to the maintainer with the attached path but I got no answers :(.
I (FAS: davidcl) can help to maintain this package (maybe as a co-maintainer).
Koji build of a flexdock patched repo : http://koji.fedoraproject.org/koji/taskinfo?taskID=3307512
I am the tardy maintainer. I saw your email, but haven't managed to look at it yet. I'll have a look at this in the next two days.
1) some parts of the patch seemed to be unnecessary? I.e. no non ws changes -- Am I reading that right?
2) You change com/org notation throughout the patch, but miss changing the demo bits -- there may be more, as I only looked at the patch context. Its possible some of this does not hit the build, but it might be nice to be consistent -- java is notably bad for inconsistent library paths.
Don't worry about addressing them now (unless I don't respond in the 2 day window), as there is no point pinging this backwards and forwards.
I've given you commit access, so you can proceed without me if I do not reply in a timely manner. If the access doesn't come through (I had problems previously due to the JS used on the access page), then just ping me again.
thanks for the FAS access.
1) I will try to reduce patch size. My major modification is against flexdock-generate-tarball.sh . Are you ok with that part ?
2) I will try to update this patch soon to be more consistent.
I have committed a modified version of your patch, with the whitespace dropped, and I have not included the dropping of the ant task for the demos. Instead I delete the jmf-using demos.
I have not yet initiated an update, but have committed it to the "fedpkg" git repo.
Thanks for the commit, build and run fine for me. I have performed a koji build at https://koji.fedoraproject.org/koji/taskinfo?taskID=3325522 .
I think we can merge for f16. I need it to complete the Scilab packaging. Are you OK with that ?
Fine by me. Marking this as closed.
Any chance to get it on f16 ? scilab depends on flexdock >= 0.5.2