Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 735008

Summary:	memory leak on volume creation with non-existent backing file
Product:	Red Hat Enterprise Linux 6	Reporter:	Nan Zhang <nzhang>
Component:	libvirt	Assignee:	Eric Blake <eblake>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.2	CC:	ajia, dyuan, eblake, mzhan, rwu, veillard, whuang, xhu
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-0.9.4-8.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 11:27:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nan Zhang 2011-09-01 07:22:49 UTC

Description of problem:
There is a leaked reference when fail to create volume with non-existent backing file.

Version-Release number of selected component (if applicable):
libvirt-0.9.4-7.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
# virsh vol-list default
Name                 Path
-----------------------------------------
foo.img              /var/lib/libvirt/images/foo.img
test.img             /var/lib/libvirt/images/test.img
win7.img             /var/lib/libvirt/images/win7.img

# virsh vol-create-as default foo-new.img 4G --allocation 0 --format qcow2 --backing-vol foo.qcow2 --backing-vol-format qcow2
error: failed to get vol 'foo.qcow2'
error: Storage volume not found: no storage vol with matching path

error: Failed to disconnect from the hypervisor, 1 leaked reference(s)

Actual results:
There is a leaked reference error occurs.

Expected results:
No leaked reference errors.

Additional info:

Comment 1 Alex Jia 2011-09-02 07:45:40 UTC

Patch for upstream:

commit 59d4b170fc422d5f86977811b8b91b15ee133e94
Author: Alex Jia <ajia>
Date:   Fri Sep 2 01:12:00 2011 +0800

    virsh: avoid memory leak on cmdVolCreateAs
    
    * tools/virsh.c: fix memory leak on cmdVolCreateAs function.
    
    * Detected in valgrind run:
    
    ==4746==
    ==4746== 48 (40 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 26 of 52
    ==4746==    at 0x4A04A28: calloc (vg_replace_malloc.c:467)
    ==4746==    by 0x4C76E51: virAlloc (memory.c:101)
    ==4746==    by 0x4CD9418: virGetStoragePool (datatypes.c:592)
    ==4746==    by 0x4D21367: remoteStoragePoolLookupByName (remote_driver.c:4126)
    ==4746==    by 0x4CE42B0: virStoragePoolLookupByName (libvirt.c:10232)
    ==4746==    by 0x40C276: vshCommandOptPoolBy (virsh.c:13660)
    ==4746==    by 0x40CA37: cmdVolCreateAs (virsh.c:8094)
    ==4746==    by 0x412AF2: vshCommandRun (virsh.c:13770)
    ==4746==    by 0x422F11: main (virsh.c:15127)
    ==4746==
    ==4746== 1,011 bytes in 1 blocks are definitely lost in loss record 45 of 52
    ==4746==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
    ==4746==    by 0x4A06167: realloc (vg_replace_malloc.c:525)
    ==4746==    by 0x4C76ECB: virReallocN (memory.c:161)
    ==4746==    by 0x4C60319: virBufferGrow (buf.c:72)
    ==4746==    by 0x4C606AA: virBufferAdd (buf.c:106)
    ==4746==    by 0x40CB37: cmdVolCreateAs (virsh.c:8118)
    ==4746==    by 0x412AF2: vshCommandRun (virsh.c:13770)
    ==4746==    by 0x422F11: main (virsh.c:15127)
    ==4746==
    ==4746== LEAK SUMMARY:
    ==4746==    definitely lost: 1,051 bytes in 2 blocks
    ==4746==    indirectly lost: 8 bytes in 1 blocks
    ==4746==      possibly lost: 0 bytes in 0 blocks
    ==4746==    still reachable: 390,767 bytes in 1,373 blocks
    ==4746==         suppressed: 0 bytes in 0 blocks
    
    * How to reproduce?
    
    % valgrind -v --leak-check=full virsh vol-create-as default foo.img 10M \
      --allocation 0 --format qcow2 --backing-vol bar.img
    
    Notes: bar.img doesn't exist.
    
    Signed-off-by: Alex Jia <ajia>

Comment 2 Eric Blake 2011-09-02 13:48:40 UTC

In POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-September/msg00047.html

Comment 5 errata-xmlrpc 2011-12-06 11:27:51 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html