Bug 735145 (kmplot) - Review Request: kmplot - Mathematical Function Plotter
Summary: Review Request: kmplot - Mathematical Function Plotter
Keywords:
Status: CLOSED RAWHIDE
Alias: kmplot
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: libkdeedu
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-09-01 15:31 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-25 18:45:47 UTC
rnovacek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2011-09-01 15:31:16 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeedu/kmplot.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeedu/kmplot-4.7.0-10.fc15.src.rpm
Description: Mathematical Function Plotter

Comment 1 Susi Lehtola 2011-09-01 20:29:27 UTC
Shouldn't this obsolete kdeedu-math < 4.7.0-10 instead of conflicting with it..?

Also, I'm wondering why KDE has two plotting programs; this one and bug #735132...

Comment 2 Rex Dieter 2011-09-01 21:15:56 UTC
We'll continue to have kdeedu (and friends) metapackages for upgrade path,
http://rdieter.fedorapeople.org/rpms/kdeedu/kdeedu.spec

(similar to how we've handled split packaging in kdeutils, kdemultimedia, kdesdk, kdegraphics)

Comment 3 Radek Novacek 2011-09-22 13:09:10 UTC
Name: ok
License: ok
Source: ok
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: NA
Desktop file validations: ok 
Locales: ok
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint: no need to fix
kmplot.x86_64: E: script-without-shebang /usr/share/applications/kde4/kmplot.desktop

No issues found, setting fedora-review+.

Comment 4 Susi Lehtola 2011-09-22 13:32:12 UTC
Radek: you should check

http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

as well.

Comment 5 Susi Lehtola 2011-09-22 13:37:09 UTC
I see that the upgrade path is sane due to the kdeedu metapackage, but this procedure goes against the current packaging guidelines.

Furthermore, IIRC metapackages aren't allowed in Fedora. Or are kdeedu and friends going away soon?


You could kill kdeedu and the other packages straight away, were you just to add

Obsoletes: kdeedu-math < foover-foorel
Provides: kdeedu-math = fooveer-foorel

in every package that used to be in kdeedu-math.

Comment 6 Rex Dieter 2011-09-22 13:44:00 UTC
Using a metapacakge here is the most sane thing to do, imo.  Anything else is prone to errors.

Comment 7 Rex Dieter 2011-09-22 13:44:52 UTC
Oh, and kdeedu metapackage may or may not end up being temporary (for a release or 2, the kde-sig hasn't made any final decisions... yet)

Comment 8 Rex Dieter 2011-09-22 13:45:40 UTC
Thanks!

New Package SCM Request
=======================
Package Name: kig
Short Description: Interactive Geometry
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16

Comment 9 Rex Dieter 2011-09-22 13:46:49 UTC
Eek, make that:

New Package SCM Request
=======================
Package Name: kmplot
Short Description: Mathematical Function Plotter
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16

Comment 10 Gwyn Ciesla 2011-09-24 15:43:44 UTC
Git done (by process-git-requests).

Comment 11 Rex Dieter 2011-09-25 18:45:47 UTC
import


Note You need to log in before you can comment on or make changes to this bug.