Bug 735151 (rocs) - Review Request: rocs - Graph Theory IDE
Summary: Review Request: rocs - Graph Theory IDE
Alias: rocs
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
Depends On: libkdeedu
Blocks: kde-reviews
TreeView+ depends on / blocked
Reported: 2011-09-01 15:37 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-09-26 14:30:05 UTC
Type: ---
rnovacek: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Comment 1 Clément DAVID 2011-09-18 13:40:13 UTC
Just a remark before a formal review. Building and installing is fine but launching rocs failed with :
"A KDE Text Editor could not be found, 
 please, check your installation"

Installing kate-part solve this problem.

Comment 2 Rex Dieter 2011-09-18 17:49:12 UTC
http://rdieter.fedorapeople.org/rpms/kdeedu/rocs.specSpec URL: 

* Sun Sep 18 2011 Rex Dieter <rdieter@fedoraproject.org> 4.7.1-1
- Requires: kate-part
- 4.7.1

Comment 3 Radek Novacek 2011-09-23 07:27:50 UTC
Name: ok
License: some files are GPLv3+, so license in spec should probably be GPLv3+ too.
Source: ok
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: ok
Desktop file validations: ok
Locales: ok
Docs: ok
Devel: ok
Files: ok
Build: ok
rpmlint: upstream should fix the incorrect-fsf-address in COPYING
rocs.x86_64: E: incorrect-fsf-address /usr/share/doc/rocs-4.7.1/COPYING
rocs.x86_64: E: script-without-shebang /usr/share/applications/kde4/rocs.desktop
rocs.x86_64: W: no-manual-page-for-binary rocs
rocs-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment
rocs-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment
rocs-libs.x86_64: W: no-documentation
rocs-devel.x86_64: W: no-documentation

Comment 4 Rex Dieter 2011-09-23 15:19:17 UTC
http://rdieter.fedorapeople.org/rpms/kdeedu/rocs.specSpec URL: 

* Fri Sep 23 2011 Rex Dieter <rdieter@fedoraproject.org> 4.7.1-3
- License: GPLv3+

Comment 5 Radek Novacek 2011-09-26 06:40:45 UTC
Thanks for fixing the issues, setting fedora-review+.

Comment 6 Rex Dieter 2011-09-26 13:05:03 UTC
New Package SCM Request
Package Name: rocs
Short Description: Graph Theory IDE
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16

Comment 7 Gwyn Ciesla 2011-09-26 14:16:07 UTC
Git done (by process-git-requests).

Comment 8 Rex Dieter 2011-09-26 14:30:05 UTC

Note You need to log in before you can comment on or make changes to this bug.